[AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.ch...@amd.com>
Hi Ard, please also update Daniel's email address to Daniel Schaefer <g...@danielschaefer.me> Thanks > -----Original Message----- > From: Ard Biesheuvel <a...@kernel.org> > Sent: Monday, September 5, 2022 9:56 PM > To: Wenyi Xie <xiewen...@huawei.com> > Cc: devel@edk2.groups.io; quic_llind...@quicinc.com; > ardb+tianoc...@kernel.org; Chang, Abner <abner.ch...@amd.com>; > daniel.schae...@hpe.com; songdongku...@huawei.com > Subject: Re: [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix > compile warning > > [CAUTION: External Email] > > On Wed, 3 Aug 2022 at 11:27, Wenyi Xie <xiewen...@huawei.com> wrote: > > > > The value of gTimeOut is from PcdGdbMaxPacketRetryCount, and this PCD > > is UINT32. So change the declaratrion of gTimeOut to UINT32 to fix > > compile warning. > > > > Cc: Leif Lindholm <quic_llind...@quicinc.com> > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > Cc: Abner Chang <abner.ch...@amd.com> > > Cc: Daniel Schaefer <daniel.schae...@hpe.com> > > Signed-off-by: Wenyi Xie <xiewen...@huawei.com> > > --- > > EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2 > > +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c > > b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c > > index d53a5fe47f18..d54e1cf7e094 100644 > > --- > > a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c > > +++ b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib. > > +++ c > > @@ -17,7 +17,7 @@ > > #include <Protocol/DebugPort.h> > > > > EFI_DEBUGPORT_PROTOCOL *gDebugPort = NULL; > > -UINTN gTimeOut = 0; > > +UINT32 gTimeOut = 0; > > > > /** > > The constructor function initializes the UART. > > -- > > 2.20.1.windows.1 > > > > Merged as #3287 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93190): https://edk2.groups.io/g/devel/message/93190 Mute This Topic: https://groups.io/mt/92788833/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-