Reviewed-by: Jiewen Yao <jiewen....@intel.com>
Merged https://github.com/tianocore/edk2/pull/3291
> -----Original Message-----
> From: Xu, Min M <min.m...@intel.com>
> Sent: Friday, August 26, 2022 8:41 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M <min.m...@intel.com>; Aktas, Erdem
> <erdemak...@google.com>; James Bottomley <j...@linux.ibm.com>; Yao,
> Jiewen <jiewen....@intel.com>; Gerd Hoffmann <kra...@redhat.com>;
> Tom Lendacky <thomas.lenda...@amd.com>
> Subject: [PATCH 1/1] OvmfPkg: Set default Pci PCDs in Tdx guest
>
> From: Min M Xu <min.m...@intel.com>
>
> In previous implementation below Pci related PCDs were set based on the
> ResourceDescriptor passed in TdHob.
> - PcdPciMmio64Base / PcdPciMmio64Size
> - PcdPciMmio32Base / PcdPciMmio32Size
> - PcdPciIoBase / PcdPciIoSize
>
> The PCDs will not be set if TdHob doesn't include these information. This
> patch set the PCDs with the information initialized in PlatformInitLib
> by default. Then TdxDxe will check the ResourceDescriptor in TdHob and
> reset them if they're included.
>
> Cc: Erdem Aktas <erdemak...@google.com>
> Cc: James Bottomley <j...@linux.ibm.com>
> Cc: Jiewen Yao <jiewen....@intel.com>
> Cc: Gerd Hoffmann <kra...@redhat.com>
> Cc: Tom Lendacky <thomas.lenda...@amd.com>
> Signed-off-by: Min Xu <min.m...@intel.com>
> ---
> OvmfPkg/TdxDxe/TdxDxe.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/OvmfPkg/TdxDxe/TdxDxe.c b/OvmfPkg/TdxDxe/TdxDxe.c
> index 2318db989792..bfdaef59dd58 100644
> --- a/OvmfPkg/TdxDxe/TdxDxe.c
> +++ b/OvmfPkg/TdxDxe/TdxDxe.c
> @@ -68,20 +68,20 @@ SetPcdSettings (
> PcdStatus = PcdSet64S (PcdTdxSharedBitMask, TdSharedPageMask ());
> ASSERT_RETURN_ERROR (PcdStatus);
> DEBUG ((DEBUG_INFO, "TdxSharedBitMask=0x%llx\n", PcdGet64
> (PcdTdxSharedBitMask)));
> - } else {
> - PcdStatus = PcdSet64S (PcdPciMmio64Base, PlatformInfoHob-
> >PcdPciMmio64Base);
> - ASSERT_RETURN_ERROR (PcdStatus);
> - PcdStatus = PcdSet64S (PcdPciMmio64Size, PlatformInfoHob-
> >PcdPciMmio64Size);
> - ASSERT_RETURN_ERROR (PcdStatus);
> - PcdStatus = PcdSet64S (PcdPciMmio32Base, PlatformInfoHob-
> >PcdPciMmio32Base);
> - ASSERT_RETURN_ERROR (PcdStatus);
> - PcdStatus = PcdSet64S (PcdPciMmio32Size, PlatformInfoHob-
> >PcdPciMmio32Size);
> - ASSERT_RETURN_ERROR (PcdStatus);
> - PcdStatus = PcdSet64S (PcdPciIoBase, PlatformInfoHob->PcdPciIoBase);
> - ASSERT_RETURN_ERROR (PcdStatus);
> - PcdStatus = PcdSet64S (PcdPciIoSize, PlatformInfoHob->PcdPciIoSize);
> - ASSERT_RETURN_ERROR (PcdStatus);
> }
> +
> + PcdStatus = PcdSet64S (PcdPciMmio64Base, PlatformInfoHob-
> >PcdPciMmio64Base);
> + ASSERT_RETURN_ERROR (PcdStatus);
> + PcdStatus = PcdSet64S (PcdPciMmio64Size, PlatformInfoHob-
> >PcdPciMmio64Size);
> + ASSERT_RETURN_ERROR (PcdStatus);
> + PcdStatus = PcdSet64S (PcdPciMmio32Base, PlatformInfoHob-
> >PcdPciMmio32Base);
> + ASSERT_RETURN_ERROR (PcdStatus);
> + PcdStatus = PcdSet64S (PcdPciMmio32Size, PlatformInfoHob-
> >PcdPciMmio32Size);
> + ASSERT_RETURN_ERROR (PcdStatus);
> + PcdStatus = PcdSet64S (PcdPciIoBase, PlatformInfoHob->PcdPciIoBase);
> + ASSERT_RETURN_ERROR (PcdStatus);
> + PcdStatus = PcdSet64S (PcdPciIoSize, PlatformInfoHob->PcdPciIoSize);
> + ASSERT_RETURN_ERROR (PcdStatus);
> }
>
> /**
> --
> 2.29.2.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93182): https://edk2.groups.io/g/devel/message/93182
Mute This Topic: https://groups.io/mt/93260974/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
