Pushed as 3c3b116801..d9994fa7e1 -----Original Message----- From: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> Sent: Wednesday, August 31, 2022 5:55 PM To: Oram, Isaac W <isaac.w.o...@intel.com>; devel@edk2.groups.io Cc: Chiu, Chasel <chasel.c...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com>; Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Luo, Heng <heng....@intel.com>; Kethi Reddy, Deepika <deepika.kethi.re...@intel.com>; Esakkithevar, Kathappan <kathappan.esakkithe...@intel.com> Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting
Hi Isaac, Good cleanup! For the series... Reviewed-by: Nate DeSimone <nathaniel.l.desim...@intel.com> -----Original Message----- From: Oram, Isaac W <isaac.w.o...@intel.com> Sent: Friday, July 22, 2022 11:46 AM To: devel@edk2.groups.io Cc: Oram, Isaac W <isaac.w.o...@intel.com>; Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com>; Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Luo, Heng <heng....@intel.com>; Kethi Reddy, Deepika <deepika.kethi.re...@intel.com>; Esakkithevar, Kathappan <kathappan.esakkithe...@intel.com> Subject: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting These changes simplify the logic for board porting by creating common include files for initializing PCD and for some stage specific logic commonly implemented. Removes the PERFORMANCE_ENABLE flag and rely on the gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable only. Simplifies the WhitleyOpenBoardPkg performance monitoring infrastructure. Removes gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable and disable handler profiling on RELEASE builds. The net result is removal of unnecessary or duplicate options and the reduction in duplicate code with increases in comments. Cc: Chasel Chiu <chasel.c...@intel.com> Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> Cc: Liming Gao <gaolim...@byosoft.com.cn> Cc: Eric Dong <eric.d...@intel.com> Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> Cc: Heng Luo <heng....@intel.com> Cc: Deepika Kethi Reddy <deepika.kethi.re...@intel.com> Cc: Kathappan Esakkithevar <kathappan.esakkithe...@intel.com> Isaac Oram (13): MinPlatformPkg/Include: Simplify board creation WhitleyOpenBoardPkg/Build: Reduce duplicate code Features/Intel: Reduce duplicate code WhitleyOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg/Include: Simplify build logic BoardModulePkg/Include: Add include for stage behavior logic WhiskeyLakeOpenBoardPkg/Build: Reduce unnecessary code TigerLakeOpenBoardPkg/Build: Reduce unnecessary code SimicsOpenBoardPkg/Build: Reduce unnecessary code PurleyOpenBoardPkg/Build: Reduce unnecessary code KabylakeOpenBoardPkg/Build: Reduce unnecessary code CometlakeOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg: Remove unnecessary feature controls .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 13 ++-- .../AcpiDebugFeaturePkg.dsc | 12 ++-- .../BeepDebugFeaturePkg.dsc | 15 ++-- .../PostCodeDebugFeaturePkg.dsc | 15 ++-- .../NetworkFeaturePkg/NetworkFeaturePkg.dsc | 13 ++-- .../IpmiFeaturePkg/IpmiFeaturePkg.dsc | 13 ++-- .../SpcrFeaturePkg/SpcrFeaturePkg.dsc | 13 ++-- .../S3FeaturePkg/S3FeaturePkg.dsc | 13 ++-- .../SmbiosFeaturePkg/SmbiosFeaturePkg.dsc | 13 ++-- .../TemplateFeaturePkg/TemplateFeaturePkg.dsc | 13 ++-- .../LogoFeaturePkg/LogoFeaturePkg.dsc | 12 ++-- .../UserAuthFeaturePkg/UserAuthFeaturePkg.dsc | 13 ++-- .../VirtualKeyboardFeaturePkg.dsc | 13 ++-- .../Include/Dsc/CommonStageConfig.dsc.inc | 37 ++++++++++ .../CometlakeURvp/OpenBoardPkgPcd.dsc | 51 ++++--------- .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 52 ++++---------- .../GalagoPro3/OpenBoardPkgPcd.dsc | 51 ++++--------- .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 51 ++++--------- .../Include/Dsc/CoreCommonLib.dsc | 6 +- .../Include/Dsc/CoreDxeInclude.dsc | 23 +++--- .../Dsc/MinPlatformFeaturesPcd.dsc.inc | 25 +++++++ .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 - .../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++-- .../BoardMtOlympus/PlatformPkgConfig.dsc | 46 ++++-------- .../BoardMtOlympus/PlatformPkgPcd.dsc | 52 ++++---------- .../BoardTiogaPass/PlatformPkgConfig.dsc | 48 ++++--------- .../BoardTiogaPass/PlatformPkgPcd.dsc | 52 ++++---------- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 51 ++++--------- .../TigerlakeURvp/OpenBoardPkgPcd.dsc | 52 ++++---------- .../UpXtreme/OpenBoardPkgPcd.dsc | 51 ++++--------- .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 51 ++++--------- .../Aowanda/PlatformPkg.dsc | 3 - .../BoardPortTemplate/PlatformPkg.dsc | 50 +++++++++++++ ...blePerformanceMonitoringInfrastructure.dsc | 5 +- ...anceMonitoringInfrastructurePostMemory.fdf | 5 +- ...manceMonitoringInfrastructurePreMemory.fdf | 2 +- .../JunctionCity/PlatformPkg.dsc | 3 - .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 72 ++++++------------- .../WhitleyOpenBoardPkg/PlatformPkgConfig.dsc | 2 - 39 files changed, 382 insertions(+), 645 deletions(-) create mode 100644 Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc create mode 100644 Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc -- 2.36.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93017): https://edk2.groups.io/g/devel/message/93017 Mute This Topic: https://groups.io/mt/92554226/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
