A quick compare against the SMBIOS 3.6.0. Looks good! Thanks for adding this.

Reviewed-By: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sainadh
> Nagolu via groups.io
> Sent: Wednesday, August 3, 2022 12:52 AM
> To: devel@edk2.groups.io; Sainadh Nagolu <saina...@ami.com>
> Cc: Sundaresan S <sundares...@ami.com>; Vasudevan Sambandan
> <vasudev...@ami.com>; gaolim...@byosoft.com.cn
> Subject: [edk2-devel] [PATCH] Add support for SMBIOS Spec 3.6.0 to SmBios.h
> 
> Updated SmBios.h with new fields added as part of SMBIOS 3.6.0 spec update.
> 
> Signed-off-by: Sainadh Nagolu <saina...@ami.com>
> 
> CC: Vasudevan Sambandan <vasudev...@ami.com>
> CC: Sundaresan S <sundares...@ami.com>
> 
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 88 ++++++++++++++++--------
>  1 file changed, 61 insertions(+), 27 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index c7a4971f14..3b296ab308 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1,5 +1,5 @@
>  /** @file
> 
> -  Industry Standard Definitions of SMBIOS Table Specification v3.5.0.
> 
> +  Industry Standard Definitions of SMBIOS Table Specification v3.6.0.
> 
> 
> 
>  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
> 
> @@ -722,21 +722,39 @@ typedef enum {
>  /// Processor Information2 - Processor Family2.
> 
>  ///
> 
>  typedef enum {
> 
> -  ProcessorFamilyARMv7          = 0x0100,
> 
> -  ProcessorFamilyARMv8          = 0x0101,
> 
> -  ProcessorFamilySH3            = 0x0104,
> 
> -  ProcessorFamilySH4            = 0x0105,
> 
> -  ProcessorFamilyARM            = 0x0118,
> 
> -  ProcessorFamilyStrongARM      = 0x0119,
> 
> -  ProcessorFamily6x86           = 0x012C,
> 
> -  ProcessorFamilyMediaGX        = 0x012D,
> 
> -  ProcessorFamilyMII            = 0x012E,
> 
> -  ProcessorFamilyWinChip        = 0x0140,
> 
> -  ProcessorFamilyDSP            = 0x015E,
> 
> -  ProcessorFamilyVideoProcessor = 0x01F4,
> 
> -  ProcessorFamilyRiscvRV32      = 0x0200,
> 
> -  ProcessorFamilyRiscVRV64      = 0x0201,
> 
> -  ProcessorFamilyRiscVRV128     = 0x0202
> 
> +  ProcessorFamilyARMv7                = 0x0100,
> 
> +  ProcessorFamilyARMv8                = 0x0101,
> 
> +  ProcessorFamilyARMv9                = 0x0102,
> 
> +  ProcessorFamilySH3                  = 0x0104,
> 
> +  ProcessorFamilySH4                  = 0x0105,
> 
> +  ProcessorFamilyARM                  = 0x0118,
> 
> +  ProcessorFamilyStrongARM            = 0x0119,
> 
> +  ProcessorFamily6x86                 = 0x012C,
> 
> +  ProcessorFamilyMediaGX              = 0x012D,
> 
> +  ProcessorFamilyMII                  = 0x012E,
> 
> +  ProcessorFamilyWinChip              = 0x0140,
> 
> +  ProcessorFamilyDSP                  = 0x015E,
> 
> +  ProcessorFamilyVideoProcessor       = 0x01F4,
> 
> +  ProcessorFamilyRiscvRV32            = 0x0200,
> 
> +  ProcessorFamilyRiscVRV64            = 0x0201,
> 
> +  ProcessorFamilyRiscVRV128           = 0x0202,
> 
> +  ProcessorFamilyLoongArch            = 0x0258,
> 
> +  ProcessorFamilyLoongson1            = 0x0259,
> 
> +  ProcessorFamilyLoongson2            = 0x025A,
> 
> +  ProcessorFamilyLoongson3            = 0x025B,
> 
> +  ProcessorFamilyLoongson2K           = 0x025C,
> 
> +  ProcessorFamilyLoongson3A           = 0x025D,
> 
> +  ProcessorFamilyLoongson3B           = 0x025E,
> 
> +  ProcessorFamilyLoongson3C           = 0x025F,
> 
> +  ProcessorFamilyLoongson3D           = 0x0260,
> 
> +  ProcessorFamilyLoongson3E           = 0x0261,
> 
> +  ProcessorFamilyDualCoreLoongson2K   = 0x0262,
> 
> +  ProcessorFamilyQuadCoreLoongson3A   = 0x026C,
> 
> +  ProcessorFamilyMultiCoreLoongson3A  = 0x026D,
> 
> +  ProcessorFamilyQuadCoreLoongson3B   = 0x026E,
> 
> +  ProcessorFamilyMultiCoreLoongson3B  = 0x026F,
> 
> +  ProcessorFamilyMultiCoreLoongson3C  = 0x0270,
> 
> +  ProcessorFamilyMultiCoreLoongson3D  = 0x0271
> 
>  } PROCESSOR_FAMILY2_DATA;
> 
> 
> 
>  ///
> 
> @@ -817,7 +835,16 @@ typedef enum {
>    ProcessorUpgradeSocketBGA1528   = 0x3C,
> 
>    ProcessorUpgradeSocketLGA4189   = 0x3D,
> 
>    ProcessorUpgradeSocketLGA1200   = 0x3E,
> 
> -  ProcessorUpgradeSocketLGA4677   = 0x3F
> 
> +  ProcessorUpgradeSocketLGA4677   = 0x3F,
> 
> +  ProcessorUpgradeSocketLGA1700   = 0x40,
> 
> +  ProcessorUpgradeSocketBGA1744   = 0x41,
> 
> +  ProcessorUpgradeSocketBGA1781   = 0x42,
> 
> +  ProcessorUpgradeSocketBGA1211   = 0x43,
> 
> +  ProcessorUpgradeSocketBGA2422   = 0x44,
> 
> +  ProcessorUpgradeSocketLGA1211   = 0x45,
> 
> +  ProcessorUpgradeSocketLGA2422   = 0x46,
> 
> +  ProcessorUpgradeSocketLGA5773   = 0x47,
> 
> +  ProcessorUpgradeSocketBGA5773   = 0x48
> 
>  } PROCESSOR_UPGRADE;
> 
> 
> 
>  ///
> 
> @@ -946,6 +973,10 @@ typedef struct {
>    UINT16                 CoreCount2;
> 
>    UINT16                 EnabledCoreCount2;
> 
>    UINT16                 ThreadCount2;
> 
> +  //
> 
> +  // Add for smbios 3.6
> 
> +  //
> 
> +  UINT16                 ThreadEnabled;
> 
>  } SMBIOS_TABLE_TYPE4;
> 
> 
> 
>  ///
> 
> @@ -1811,7 +1842,8 @@ typedef enum {
>    MemoryTypeHBM                      = 0x20,
> 
>    MemoryTypeHBM2                     = 0x21,
> 
>    MemoryTypeDdr5                     = 0x22,
> 
> -  MemoryTypeLpddr5                   = 0x23
> 
> +  MemoryTypeLpddr5                   = 0x23,
> 
> +  MemoryTypeHBM3                     = 0x24
> 
>  } MEMORY_DEVICE_TYPE;
> 
> 
> 
>  ///
> 
> @@ -2660,15 +2692,17 @@ typedef struct {
>  /// Processor Specific Block - Processor Architecture Type
> 
>  ///
> 
>  typedef enum {
> 
> -  ProcessorSpecificBlockArchTypeReserved   = 0x00,
> 
> -  ProcessorSpecificBlockArchTypeIa32       = 0x01,
> 
> -  ProcessorSpecificBlockArchTypeX64        = 0x02,
> 
> -  ProcessorSpecificBlockArchTypeItanium    = 0x03,
> 
> -  ProcessorSpecificBlockArchTypeAarch32    = 0x04,
> 
> -  ProcessorSpecificBlockArchTypeAarch64    = 0x05,
> 
> -  ProcessorSpecificBlockArchTypeRiscVRV32  = 0x06,
> 
> -  ProcessorSpecificBlockArchTypeRiscVRV64  = 0x07,
> 
> -  ProcessorSpecificBlockArchTypeRiscVRV128 = 0x08
> 
> +  ProcessorSpecificBlockArchTypeReserved    = 0x00,
> 
> +  ProcessorSpecificBlockArchTypeIa32        = 0x01,
> 
> +  ProcessorSpecificBlockArchTypeX64         = 0x02,
> 
> +  ProcessorSpecificBlockArchTypeItanium     = 0x03,
> 
> +  ProcessorSpecificBlockArchTypeAarch32     = 0x04,
> 
> +  ProcessorSpecificBlockArchTypeAarch64     = 0x05,
> 
> +  ProcessorSpecificBlockArchTypeRiscVRV32   = 0x06,
> 
> +  ProcessorSpecificBlockArchTypeRiscVRV64   = 0x07,
> 
> +  ProcessorSpecificBlockArchTypeRiscVRV128  = 0x08,
> 
> +  ProcessorSpecificBlockArchTypeLoongArch32 = 0x09,
> 
> +  ProcessorSpecificBlockArchTypeLoongArch64 = 0x0A
> 
>  } PROCESSOR_SPECIFIC_BLOCK_ARCH_TYPE;
> 
> 
> 
>  ///
> 
> --
> 2.36.0.windows.1
> -The information contained in this message may be confidential and proprietary
> to American Megatrends (AMI). This communication is intended to be read only
> by the individual or entity to whom it is addressed or by their designee. If 
> the
> reader of this message is not the intended recipient, you are on notice that 
> any
> distribution of this message, in any form, is strictly prohibited. Please 
> promptly
> notify the sender by reply e-mail or by telephone at 770-246-8600, and then
> delete or destroy all copies of the transmission.
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92082): https://edk2.groups.io/g/devel/message/92082
Mute This Topic: https://groups.io/mt/92786852/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to