On Tue, 2 Aug 2022 at 20:04, <mikub...@linux.microsoft.com> wrote:
>
> From: Michael Kubacki <michael.kuba...@microsoft.com>
>
> These debug messages are repeated in both NorFlashBlockIoReadBlocks()
> and NorFlashBlockIoWriteBlocks():
>
> "NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x"
> "bytes (%d kB), BufferPtr @ 0x%08x)\n"
>
> Although this requires 5 arguments, only 4 are provided. The kilobyte
> value was never given.
>
> This change removes that specifier so the 4 arguments match the 4
> specifiers in the debug macro.
>
> Cc: Leif Lindholm <quic_llind...@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
> Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com>
Reviewed-by: Ard Biesheuve; <a...@kernel.org>
> ---
> ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c
> b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c
> index 5afab0a79fa2..e671108e2bcf 100644
> --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c
> +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c
> @@ -54,7 +54,7 @@ NorFlashBlockIoReadBlocks (
> Instance = INSTANCE_FROM_BLKIO_THIS (This);
> Media = This->Media;
>
> - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=0x%x, Lba=%ld,
> BufferSize=0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba,
> BufferSizeInBytes, Buffer));
> + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=0x%x, Lba=%ld,
> BufferSize=0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba,
> BufferSizeInBytes, Buffer));
>
> if (!Media) {
> Status = EFI_INVALID_PARAMETER;
> @@ -89,7 +89,7 @@ NorFlashBlockIoWriteBlocks (
>
> Instance = INSTANCE_FROM_BLKIO_THIS (This);
>
> - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld,
> BufferSize=0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba,
> BufferSizeInBytes, Buffer));
> + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld,
> BufferSize=0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba,
> BufferSizeInBytes, Buffer));
>
> if ( !This->Media->MediaPresent ) {
> Status = EFI_NO_MEDIA;
> --
> 2.28.0.windows.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92079): https://edk2.groups.io/g/devel/message/92079
Mute This Topic: https://groups.io/mt/92776307/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
