Reviewed-by: Guo Dong <[email protected]>
-----Original Message----- From: Lu, James <[email protected]> Sent: Tuesday, July 19, 2022 11:58 PM To: [email protected] Cc: Ni, Ray <[email protected]>; Dong, Guo <[email protected]>; Guo, Gua <[email protected]> Subject: RE: [PATCH] UefiPayloadPkg: Fix RelaAddress type always mismatch in if condition Hi Ray, Any comment on this patch? Thanks, James -----Original Message----- From: Lu, James <[email protected]> Sent: Monday, July 11, 2022 1:06 PM To: [email protected] Cc: Lu, James <[email protected]>; Ni, Ray <[email protected]>; Dong, Guo <[email protected]>; Guo, Gua <[email protected]> Subject: [PATCH] UefiPayloadPkg: Fix RelaAddress type always mismatch in if condition From: James Lu <[email protected]> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3984 Under function RolocateElfDynamic() in Elf32Lib.c if (RelaAddress == MAX_UINT64) is always FALSE while RelaAddress is UINT32 Fix is to modify if condition check to "if (RelaAddress == MAX_UINT32)" Cc: Ray Ni <[email protected]> Cc: Guo Dong <[email protected]> Cc: Gua Guo <[email protected]> Signed-off-by: James Lu <[email protected]> --- UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c index b002c4b9cf..cb915e7142 100644 --- a/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c +++ b/UefiPayloadPkg/PayloadLoaderPeim/ElfLib/Elf32Lib.c @@ -292,7 +292,7 @@ RelocateElf32Dynamic ( } } - if (RelaAddress == MAX_UINT64) {+ if (RelaAddress == MAX_UINT32) { ASSERT (RelaCount == 0); ASSERT (RelaEntrySize == 0); ASSERT (RelaSize == 0);-- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91608): https://edk2.groups.io/g/devel/message/91608 Mute This Topic: https://groups.io/mt/92303921/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
