@Ni, Ray<mailto:[email protected]>
Below url is pull request link. May I get your help to add push label ? Have any concern, please also share for me. URL: https://github.com/tianocore/edk2/pull/3015 Thanks, Gua -----Original Message----- From: Ni, Ray <[email protected]> Sent: Monday, June 27, 2022 2:53 PM To: Guo, Gua <[email protected]>; [email protected] Cc: Dong, Guo <[email protected]>; Lu, James <[email protected]> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec Reviewed-by: Ray Ni <[email protected]<mailto:[email protected]>> > -----Original Message----- > From: Guo, Gua <[email protected]<mailto:[email protected]>> > Sent: Monday, June 27, 2022 1:03 PM > To: Ni, Ray <[email protected]<mailto:[email protected]>>; > [email protected]<mailto:[email protected]> > Cc: Dong, Guo <[email protected]<mailto:[email protected]>>; Lu, James > <[email protected]<mailto:[email protected]>> > Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL > spec > > Yes, #2 is chosen in by the python interpreter. > > -----Original Message----- > From: Guo, Gua > Sent: Monday, June 27, 2022 12:07 PM > To: Ni, Ray <[email protected]<mailto:[email protected]>>; > [email protected]<mailto:[email protected]> > Cc: Dong, Guo <[email protected]<mailto:[email protected]>>; Lu, James > <[email protected]<mailto:[email protected]>> > Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL > spec > > The python logic will like for below > > > upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0 > =========> > > if BuildTarget == "DEBUG": > > upld_info_hdr.Attribute |= 1 > > else: > > upld_info_hdr.Attribute |= 0 > > Thanks, > Gua > > -----Original Message----- > From: Ni, Ray <[email protected]<mailto:[email protected]>> > Sent: Monday, June 27, 2022 11:44 AM > To: Guo, Gua <[email protected]<mailto:[email protected]>>; > [email protected]<mailto:[email protected]> > Cc: Dong, Guo <[email protected]<mailto:[email protected]>>; Lu, James > <[email protected]<mailto:[email protected]>> > Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL > spec > > > + upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0 > > > I am not python expert. Above statement might be interpreted as: > 1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0 2. > upld_info_hdr.Attribute |= (1 if BuildTarget == "DEBUG" else 0) > > Are we sure that the #2 is chosen in by the python interpreter? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90803): https://edk2.groups.io/g/devel/message/90803 Mute This Topic: https://groups.io/mt/92013929/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
