On Mon, 30 May 2022 at 12:21, Gerd Hoffmann <kra...@redhat.com> wrote:
>
> On Mon, May 30, 2022 at 11:32:03AM +0200, Ard Biesheuvel wrote:
> > Hi Gerd,
> >
> > On Mon, 30 May 2022 at 11:23, Gerd Hoffmann <kra...@redhat.com> wrote:
> > >
> > > Buildfix for `-t CLANG38 -b NOOPT -p OvmfPkg/OvmfPkgX64.dsc`.
> > >
> > > Fixes: 5f6ecaa398ba ("OvmfPkg/VirtioGpuDxe: use GopQueryMode in
> > > GopSetMode")
> > > Reported-by: Rebecca Cran <quic_rc...@quicinc.com>
> > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> > > ---
> > > OvmfPkg/VirtioGpuDxe/Gop.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/OvmfPkg/VirtioGpuDxe/Gop.c b/OvmfPkg/VirtioGpuDxe/Gop.c
> > > index 70a81c10c8b5..18b29e5a23d2 100644
> > > --- a/OvmfPkg/VirtioGpuDxe/Gop.c
> > > +++ b/OvmfPkg/VirtioGpuDxe/Gop.c
> > > @@ -509,7 +509,7 @@ GopSetMode (
> > > // Populate Mode and ModeInfo (mutable fields only).
> > > //
> > > VgpuGop->GopMode.Mode = ModeNumber;
> > > - VgpuGop->GopModeInfo = *GopModeInfo;
> > > + CopyMem(&VgpuGop->GopModeInfo, GopModeInfo, sizeof(*GopModeInfo));
> >
> > Mind if I change this to
> >
> > CopyMem (&VgpuGop->GopModeInfo, GopModeInfo, sizeof VgpuGop->GopModeInfo);
>
> No (that's what running uncrustify would have done I guess?)
>
Not sure - I don't know how to run that. But the missing space before
( caught my eye
Merged as #2925
Thanks,
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90095): https://edk2.groups.io/g/devel/message/90095
Mute This Topic: https://groups.io/mt/91427357/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
