Thanks Benjamin for the explaining. I have no other comments. Thanks, Guo
From: Benjamin Doron <benjamin.doro...@gmail.com> Sent: Friday, May 27, 2022 9:33 AM To: Dong, Guo <guo.d...@intel.com>; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Add support for logging to CBMEM console Hi Guo, Dumping some of the coreboot table shows that some smaller entries/data (such as build information) are inserted inline while larger entries use the cb_cbmem_ref structure. This may answer why some users of FindCbTag() assign the returned pointer directly to their requested structure, while this library must first dereference the console's address. For reasons unclear to me, cb_cbmem_ref->size == 0x0010, the size of the cb_cbmem_ref structure. Perhaps the structure of cb_cbmem_ref has been changed in the past and the size field informs coreboot payloads? Either way, it doesn't look like a useful field at the moment. I will add comments and submit a v3. Is there anything else that needs some comments? Regards, Benjamin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90088): https://edk2.groups.io/g/devel/message/90088 Mute This Topic: https://groups.io/mt/91273919/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
