Reviewed-by: Bob Feng <bob.c.f...@intel.com> -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jake Garver via groups.io Sent: Friday, April 8, 2022 12:59 AM To: devel@edk2.groups.io; jbra...@nvidia.com; ashishsin...@nvidia.com Cc: Jake Garver <j...@nvidia.com> Subject: [edk2-devel] [PATCH] BaseTools: Fix dependency issue in PcdValueInit
The generated Makefile was missing a dependency. This resulted in a build-time race condition if the recursive make is multi-threaded and shares job control. Signed-off-by: Jake Garver <j...@nvidia.com> --- BaseTools/Source/Python/Workspace/DscBuildData.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py index fc1e773417..d55ea1bbe2 100644 --- a/BaseTools/Source/Python/Workspace/DscBuildData.py +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py @@ -97,7 +97,8 @@ PcdMakefileEnd = ''' AppTarget = ''' all: $(APPFILE) -$(APPFILE): $(OBJECTS) +$(APPLICATION): $(OBJECTS) +$(APPFILE): $(APPLICATION) %s ''' -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89762): https://edk2.groups.io/g/devel/message/89762 Mute This Topic: https://groups.io/mt/90317701/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
