> -----Original Message----- > From: Tom Lendacky <thomas.lenda...@amd.com> > Sent: Thursday, May 12, 2022 10:13 PM > To: Ni, Ray <ray...@intel.com>; devel@edk2.groups.io > Cc: Dong, Eric <eric.d...@intel.com>; Kumar, Rahul1 <rahul1.ku...@intel.com>; > Michael Roth <michael.r...@amd.com>; > James Bottomley <j...@linux.ibm.com>; Xu, Min M <min.m...@intel.com>; Yao, > Jiewen <jiewen....@intel.com>; Justen, > Jordan L <jordan.l.jus...@intel.com>; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Aktas, Erdem <erdemak...@google.com>; > Gerd Hoffmann <kra...@redhat.com> > Subject: Re: [PATCH 3/4] MpInitLib: Put SEV logic in separate file > > On 5/7/22 10:13, Ray Ni wrote: > > Probably should have a commit message here explaining the reason for the > changes. > > Overall, this works, but it does seem strange to have the SwitchToRealProc > procedure in the middle of the RendezvousFunnelProc procedure. Not sure if > it would be worth just creating a second SEV nasm file (and maybe renaming > the first one): > > AmdSevRendevous.nasm > AmdSevSwitchToReal.nasm > > and then including the two in different locations.
I would prefer to keep them in one file AmdSev.nasm. > > Then you wouldn't have to change any of the size calculations either. > > If you want to keep the function within the function and eliminate the use > of SwitchToRealSize, you should probably update the struct in MpLib.h to > remove SwitchToRealSize and then update the Ia32 and X64 AsmGetAddressMap > function to no longer set SwitchToRealSize (or just reserve the field so > that none of the other offsets change and just remove the set in > AsmGetAddressMap). You are right. I will post v2 patches to remove the SwitchToRealSize/Offset fields. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89737): https://edk2.groups.io/g/devel/message/89737 Mute This Topic: https://groups.io/mt/90954628/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
