Hi,
> > diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> > b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> > index b20bcd310ad5..51a3b987967f 100644
> > --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> > +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> > @@ -1085,6 +1085,9 @@ NotifyPhase (
> > RootBridge->ResAllocNode[Index].Base = BaseAddress;
> > RootBridge->ResAllocNode[Index].Status = ResAllocated;
> > DEBUG ((DEBUG_INFO, "Success\n"));
> > + } else if (Index == TypeIo) {
> How do we tell the BaseAddress is set to UINT64 because "(BaseAddress <
> Limit)" or "gDS->AllocateMemorySpace()" returns error in AllocateResource()
> for TypeIo ?
Does the reason matter?
io resources are optional, so if there is no io address space available
it should not be a fatal error, no matter what the root cause is.
> Is "else if (Index == TypeIo && RootBridge->Io.Base == MAX_UINT64)" more
> reliable? Or I missed the code logic here?
I think it is not needed, but if you think it is better that way I can
change it.
> > + /* optional on PCIe */
> We should use double back slash for the comment in the function if my
> understanding of the coding standard is correct.
I'll fix in v4.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88858): https://edk2.groups.io/g/devel/message/88858
Mute This Topic: https://groups.io/mt/90309345/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
