Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default

[Rebecca Cran]

So your change in 56530dec1105f17455752675e4c90fb859c64836 didn't fix 
anything, because we don't output TestSuites.xml to the console: if I 
introduce a code style issue into a branch, CI still only prints the 
following:

PROGRESS - --Running ArmPkg: Uncrustify Coding Standard Test NO-TARGET --
WARNING - A file header template is not specified in the config file.
WARNING - A function header template is not specified in the config file.
ERROR - /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c
ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET 
returned 1
ERROR - Overall Build Status: Error
PROGRESS - There were 1 failures out of 13 attempts

Could we get the diff printed *there* too?

--
Rebecca Cran


On 2/25/22 14:18, Michael Kubacki wrote:
Hi Rebecca,

Sorry for the delay, I was out of office.

The diff will appear in <Workspace>/Build/TestSuites.xml. Here, I have 
intentionally introduced an error in 
UnitTestFrameworkPkg\Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c:

 Uncrustify executed against 21 files in UnitTestFrameworkPkg in 0.19 
seconds.
 </system-out><system-err>Files with formatting errors:
 Formatting errors in 
Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c
 --- 
D:\src\edk2\UnitTestFrameworkPkg\Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c
 +++ 
D:\src\edk2\UnitTestFrameworkPkg\Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c.uncrustify_plugin
 @@ -13,7 +13,7 @@
 #include &lt;Library/UnitTestLib.h&gt;
 #include &lt;Library/PrintLib.h&gt;

 -#define UNIT_TEST_NAME        "Sample Unit Test"
 +#define UNIT_TEST_NAME     "Sample Unit Test"
 #define UNIT_TEST_VERSION  "0.1"

 ///

 </system-err></testcase></testsuite></testsuites>

Thanks,
Michael

On 2/23/2022 12:48 PM, Rebecca Cran wrote:
This doesn't appear to work. If I change 
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c to introduce an 
error, then I get the following output (with verbose mode):


INFO - ------------------------------------------------
INFO - --------------Cmd Output Finished---------------
INFO - --------- Running Time (mm:ss): 00:07 ----------
INFO - ----------- Return Code: 0x00000000 ------------
INFO - ------------------------------------------------
INFO - Uncrustify executed against 1035 files in MdeModulePkg in 7.67 
seconds.

INFO - Calculating file diffs. This might take a while...
ERROR - .../edk2/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c
ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET 
returned 1
PROGRESS - --Running MdeModulePkg: Spell Check Test NO-TARGET --

So it's seeing that _output_file_diffs is True, but it appears that 
there aren't any formatted_files?





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88425): https://edk2.groups.io/g/devel/message/88425
Mute This Topic: https://groups.io/mt/89049118/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-