Hi Gerd, Could you provide a patch to fix this issue or revert the original commit?
Thanks, Bob -----Original Message----- From: Rebecca Cran <rebe...@bsdio.com> Sent: Tuesday, March 29, 2022 5:30 AM To: devel@edk2.groups.io; kra...@redhat.com Cc: Pawel Polawski <ppola...@redhat.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Chen, Christine <yuwei.c...@intel.com>; Oliver Steffen <ostef...@redhat.com>; Feng, Bob C <bob.c.f...@intel.com> Subject: Re: [edk2-devel] [PATCH 3/3] Basetools: turn off gcc12 warning This breaks building BaseTools with clang 13.1.6 on macOS: /Applications/Xcode.app/Contents/Developer/usr/bin/make -C DevicePath gcc -c -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . -I ../Include/AArch64/ -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g -O2 -Wno-error=stringop-overflow DevicePath.c -o DevicePath.o error: unknown warning option '-Werror=stringop-overflow'; did you mean '-Werror=shift-overflow'? [-Werror,-Wunknown-warning-option] -- Rebecca Cran On 3/24/22 6:04 AM, Gerd Hoffmann wrote: > In function ‘SetDevicePathEndNode’, > inlined from ‘FileDevicePath’ at DevicePathUtilities.c:857:5: > DevicePathUtilities.c:321:3: error: writing 4 bytes into a region of size 1 > [-Werror=stringop-overflow=] > 321 | memcpy (Node, &mUefiDevicePathLibEndDevicePath, sizeof > (mUefiDevicePathLibEndDevicePath)); > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from UefiDevicePathLib.h:22, > from DevicePathUtilities.c:16: > ../Include/Protocol/DevicePath.h: In function ‘FileDevicePath’: > ../Include/Protocol/DevicePath.h:51:9: note: destination object ‘Type’ of > size 1 > 51 | UINT8 Type; ///< 0x01 Hardware Device Path. > | ^~~~ > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > BaseTools/Source/C/DevicePath/GNUmakefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile > b/BaseTools/Source/C/DevicePath/GNUmakefile > index 7ca08af9662d..b05d2bddfa68 100644 > --- a/BaseTools/Source/C/DevicePath/GNUmakefile > +++ b/BaseTools/Source/C/DevicePath/GNUmakefile > @@ -13,6 +13,9 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o > DevicePathFromText.o DevicePathUtili > > include $(MAKEROOT)/Makefiles/app.makefile > > +# gcc 12 trips over device path handling BUILD_CFLAGS += > +-Wno-error=stringop-overflow > + > LIBS = -lCommon > ifeq ($(CYGWIN), CYGWIN) > LIBS += -L/lib/e2fsprogs -luuid -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88147): https://edk2.groups.io/g/devel/message/88147 Mute This Topic: https://groups.io/mt/89997416/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
