Min: This patch is good. I have no other comments in MdePkg. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Min Xu > 发送时间: 2022年3月17日 13:32 > 收件人: devel@edk2.groups.io; Xu, Min M <min.m...@intel.com> > 抄送: Michael Roth <michael.r...@amd.com>; Ni, Ray <ray...@intel.com>; > Kumar, Rahul1 <rahul1.ku...@intel.com>; Dong, Eric <eric.d...@intel.com>; > James Bottomley <j...@linux.ibm.com>; Yao, Jiewen > <jiewen....@intel.com>; Tom Lendacky <thomas.lenda...@amd.com>; > Justen, Jordan L <jordan.l.jus...@intel.com>; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Aktas, Erdem <erdemak...@google.com>; > Gerd Hoffmann <kra...@redhat.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; > Liu, Zhiguang <zhiguang....@intel.com> > 主题: Re: [edk2-devel] [PATCH V8 12/47] MdePkg: Add macro to check SEV / > TDX guest > > Hi, Liming > Can you help to review this patch? > https://edk2.groups.io/g/devel/message/87480 > > Thanks > Min > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Min Xu > > Sent: Saturday, March 12, 2022 9:54 AM > > To: devel@edk2.groups.io > > Cc: Xu, Min M <min.m...@intel.com>; Michael Roth > <michael.r...@amd.com>; > > Ni, Ray <ray...@intel.com>; Kumar, Rahul1 <rahul1.ku...@intel.com>; > Dong, > > Eric <eric.d...@intel.com>; James Bottomley <j...@linux.ibm.com>; Yao, > > Jiewen <jiewen....@intel.com>; Tom Lendacky > <thomas.lenda...@amd.com>; > > Justen, Jordan L <jordan.l.jus...@intel.com>; Ard Biesheuvel > > <ardb+tianoc...@kernel.org>; Aktas, Erdem <erdemak...@google.com>; > Gerd > > Hoffmann <kra...@redhat.com>; Kinney, Michael D > > <michael.d.kin...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; > Liu, > > Zhiguang <zhiguang....@intel.com> > > Subject: [edk2-devel] [PATCH V8 12/47] MdePkg: Add macro to check SEV / > > TDX guest > > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > Add macros CC_GUEST_IS_SEV / CC_GUEST_IS_TDX to check SEV / TDX > guest. > > > > Cc: Michael Roth <michael.r...@amd.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Rahul Kumar <rahul1.ku...@intel.com> > > Cc: Eric Dong <eric.d...@intel.com> > > Cc: James Bottomley <j...@linux.ibm.com> > > Cc: Min Xu <min.m...@intel.com> > > Cc: Jiewen Yao <jiewen....@intel.com> > > Cc: Tom Lendacky <thomas.lenda...@amd.com> > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > Cc: Erdem Aktas <erdemak...@google.com> > > Cc: Gerd Hoffmann <kra...@redhat.com> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Zhiguang Liu <zhiguang....@intel.com> > > Acked-by: Gerd Hoffmann <kra...@redhat.com> > > Signed-off-by: Min Xu <min.m...@intel.com> > > --- > > MdePkg/Include/ConfidentialComputingGuestAttr.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/MdePkg/Include/ConfidentialComputingGuestAttr.h > > b/MdePkg/Include/ConfidentialComputingGuestAttr.h > > index 6a1301801519..dd2541c6dcdf 100644 > > --- a/MdePkg/Include/ConfidentialComputingGuestAttr.h > > +++ b/MdePkg/Include/ConfidentialComputingGuestAttr.h > > @@ -22,4 +22,7 @@ typedef enum { > > CCAttrIntelTdx = 0x200, > > } CONFIDENTIAL_COMPUTING_GUEST_ATTR; > > > > +#define CC_GUEST_IS_TDX(x) ((x) == CCAttrIntelTdx) #define > > +CC_GUEST_IS_SEV(x) ((x) == CCAttrAmdSev || (x) == CCAttrAmdSevEs || > > +(x) == CCAttrAmdSevSnp) > > + > > #endif > > -- > > 2.29.2.windows.2 > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87717): https://edk2.groups.io/g/devel/message/87717 Mute This Topic: https://groups.io/mt/89859444/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
