Hi Sami, The patch is tested and looks good to me: Tested-by: Jagadeesh Ujja <[email protected]>
On Fri, Mar 11, 2022 at 6:38 PM PierreGondois <[email protected]> wrote: > > Hi Sami, > The patch looks good to me: > > Reviewed-by: Pierre Gondois <[email protected]> > > On 3/10/22 18:39, Sami Mujawar wrote: > > According to the Debug Port Table 2 (DBG2) specification, > > February 17, 2021, the NamespaceString is a NULL terminated > > ASCII string that consists of a fully qualified reference > > to the object that represents the serial port device in the > > ACPI namespace. > > > > The DBG2 table generator did not populate the full device > > path for the serial port device, and this results in a FWTS > > test failure. > > > > Therefore, populate the full namespace device path for the > > serial port in DBG2 table. > > > > Signed-off-by: Sami Mujawar <[email protected]> > > --- > > The changes can be seen at: > > https://github.com/samimujawar/edk2/tree/2105_dbg2_generator_namestring_issue_v1 > > > > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 10 > > +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git > > a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > > b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > > index > > 3d513dbd1fbe8c47d270a9e639b2797098201d91..f6dfb3d94c10980a0e7712ce9427648b69974061 > > 100644 > > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > > @@ -1,7 +1,7 @@ > > /** @file > > DBG2 Table Generator > > > > - Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.<BR> > > + Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.<BR> > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -55,13 +55,17 @@ Requirements: > > */ > > #define NAME_STR_DBG_PORT0 "COM0" > > > > +/** A string representing the full path name of the debug port 0. > > +*/ > > +#define NAMESPACE_STR_DBG_PORT0 "\\_SB_.COM0" > > + > > /** An UID representing the debug port 0. > > */ > > #define UID_DBG_PORT0 0 > > > > /** The length of the namespace string. > > */ > > -#define DBG2_NAMESPACESTRING_FIELD_SIZE sizeof (NAME_STR_DBG_PORT0) > > +#define DBG2_NAMESPACESTRING_FIELD_SIZE sizeof (NAMESPACE_STR_DBG_PORT0) > > > > /** The PL011 UART address range length. > > */ > > @@ -166,7 +170,7 @@ DBG2_TABLE AcpiDbg2 = { > > 0, // {Template}: Serial Port Subtype > > 0, // {Template}: Serial Port Base Address > > PL011_UART_LENGTH, > > - NAME_STR_DBG_PORT0 > > + NAMESPACE_STR_DBG_PORT0 > > ) > > } > > }; > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87529): https://edk2.groups.io/g/devel/message/87529 Mute This Topic: https://groups.io/mt/89691998/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
