On February 23, 2022 6:50 PM, Gerd Hoffmann wrote:
>
> > +EFI_STATUS
> > +EFIAPI
> > +InitializePlatform (
> > + EFI_HOB_PLATFORM_INFO *PlatformInfoHob
> > + )
> > +{
>
> > + Pci64Base = 0;
> > + Pci64Size = 0;
> > +
> > + FirstNonAddress = PlatformGetFirstNonAddress
> > (&Pci64Base,
> &Pci64Size, 0x800000000);
> > + PlatformInfoHob->PcdPciMmio64Base = Pci64Base;
> > + PlatformInfoHob->PcdPciMmio64Size = Pci64Size;
>
> I think here are opportunities to make the differences between PEI and PEI-
> less boot even smaller, by:
>
> (1) Allocate a PlatformInfoHob also when using PEI boot workflow.
> (2) Switch PlatformInitLib functions like PlatformGetFirstNonAddress() to
> receive a PlatformInfoHob pointer so they can update the HOB
> directly.
> (3) Add more platform info variables to PlatformInfoHob
> (FirstNonAddress, PhysMemAddressWidth for example).
>
> But I guess that kind of improvements can also be done incrementally after
> getting this upstream. It's also easier to test that kind of changes when we
> have both PEI and PEI-less variants present in the upstream repo. So I'm fine
> with deferring these changes for now.
Agree. Thanks for your understanding.
>
> Beside that: The name TdxStartupLib doesn't reflect reality any more, we
> should give it a better name.
How about PeilessStartupLib?
Thanks
Min
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86940): https://edk2.groups.io/g/devel/message/86940
Mute This Topic: https://groups.io/mt/89266118/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
