On Tue, Feb 22, 2022 at 04:53:04PM +0100, Boeuf, Sebastien wrote:
> From: Sebastien Boeuf <sebastien.bo...@intel.com>
>
> Following the model from the Xen target, CloudHv is generated as a PVH
> ELF binary to take advantage of the PVH specification.
> --- /dev/null
> +++ b/OvmfPkg/CloudHv/CloudHvElfHeaderGenerator.c
Why create a new copy of this? What are the differences to the Xen
version? I guess they are small so we can maybe have a common
ElfPvhHeaderGenerator.c with command line switches?
> - OvmfPkg/ResetVector/ResetVector.inf
> + OvmfPkg/XenResetVector/XenResetVector.inf
Why this is needed?
> +DATA = {
> + #
> + # This hex array have been generated by OvmfPkg/OvmfXenElfHeaderGenerator.c
> + # and copied manually.
How about having the generator write a .fdf.inc file which you can just
include directly without manual copying?
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86899): https://edk2.groups.io/g/devel/message/86899
Mute This Topic: https://groups.io/mt/89319391/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
