Hi Jiewen, On Wed, 2022-02-23 at 00:00 +0000, Yao, Jiewen wrote: > HI Sebastien > Here is some feedback. > > 1) Since this seems a new feature, would you please file a Bugzilla > https://bugzilla.tianocore.org/ ?
Ok I will. Just need to wait for my account to be created. > > 2) Please also include this new feature in release plan - > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning > ? Sure, I'll add a new entry in there, with the link to the bug in Bugzilla. > > 3) A clarification question: Do you want to *only* support PVH boot > in CloudHv, or PVH is one option and you still support old way? We want to support PVH only. No need for the legacy support. Unless you can think of a good reason to do so? > > 4) Please clarify if that impacts the support for TDVF. Well that's a good question. If we expect the same target (CloudHv) to support both TDX and non-TDX, that means the generated TDVF will be a PVH ELF binary, which will require some special handling from Cloud Hypervisor. Having two separate targets would simplify things a lot. What's the plan for QEMU? Will the same OVMF target cover both use cases? Thanks, Sebastien > > Thank you > Yao, Jiewen > > > -----Original Message----- > > From: Boeuf, Sebastien <[email protected]> > > Sent: Tuesday, February 22, 2022 11:53 PM > > To: [email protected] > > Cc: Yao, Jiewen <[email protected]>; Justen, Jordan L > > <[email protected]>; [email protected]; Boeuf, Sebastien > > <[email protected]> > > Subject: [PATCH 0/3] CloudHv: Rely on PVH boot specification > > > > From: Sebastien Boeuf <[email protected]> > > > > Cloud Hypervisor aims at emulating the minimal amount of legacy > > devices > > and this is why the PVH boot specification is supported. The point > > is to > > be able to share some information with the guest without the need > > for > > emulating devices that would be present on real hardware. > > > > Since Cloud Hypervisor supports loading a PVH ELF binary, the > > CloudHv > > target is updated to be generated as such. Relying on the PVH boot > > specification, we don't need to hardcode the location of the ACPI > > tables > > anymore since we can retrieve the RSDP address from the > > hvm_start_info > > structure. Same thing for the RAM below 4G, we can find this > > information > > through the PVH memmap entries rather than relying on the emulated > > CMOS. > > > > Signed-off-by: Sebastien Boeuf <[email protected]> > > > > Sebastien Boeuf (3): > > OvmfPkg: Generate CloudHv as a PVH ELF binary > > OvmfPkg: CloudHv: Retrieve RSDP address from PVH > > OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS > > > > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 + > > OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 39 +++-- > > OvmfPkg/CloudHv/CloudHvElfHeaderGenerator.c | 150 > > ++++++++++++++++++++ > > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- > > OvmfPkg/CloudHv/CloudHvX64.fdf | 95 ++++++++++++- > > OvmfPkg/Include/IndustryStandard/CloudHv.h | 5 - > > OvmfPkg/PlatformPei/MemDetect.c | 73 ++++++++++ > > OvmfPkg/PlatformPei/PlatformPei.inf | 2 + > > 8 files changed, 348 insertions(+), 20 deletions(-) > > create mode 100644 OvmfPkg/CloudHv/CloudHvElfHeaderGenerator.c > > > > -- > > 2.32.0 > --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86887): https://edk2.groups.io/g/devel/message/86887 Mute This Topic: https://groups.io/mt/89319389/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
