Thanks Ray! @S, Ashraf Ali I think we need to return 64bit pointer in 64bit build, please help to verify and confirm.
Thanks, Chasel > -----Original Message----- > From: Ni, Ray <[email protected]> > Sent: Monday, February 14, 2022 4:27 PM > To: [email protected]; S, Ashraf Ali <[email protected]> > Cc: Chiu, Chasel <[email protected]>; Desimone, Nathaniel L > <[email protected]>; Zeng, Star <[email protected]>; Kuo, Ted > <[email protected]>; Duggapu, Chinni B <[email protected]>; > Chaganty, Rangasai V <[email protected]>; Solanki, Digant H > <[email protected]>; V, Sangeetha <[email protected]> > Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort > Support for X64 Build > > Ashraf, > GetStackFramePointer() only returns the lower 32 bits of RBP. Is that > expected? > > > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Ashraf Ali S > Sent: Monday, February 14, 2022 12:27 AM > To: [email protected] > Cc: S, Ashraf Ali <[email protected]>; Chiu, Chasel > <[email protected]>; > Desimone, Nathaniel L <[email protected]>; Zeng, Star > <[email protected]>; Kuo, Ted <[email protected]>; Duggapu, Chinni B > <[email protected]>; Chaganty, Rangasai V > <[email protected]>; Solanki, Digant H > <[email protected]>; V, Sangeetha <[email protected]> > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Support > for X64 Build > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3833 > > Move FspDebug to the root of BaseFspDebugLibSerialPort since the current > nasm support for both IA32 and X64 Build, remove IA32 from INF file. > > Cc: Chasel Chiu <[email protected]> > Cc: Nate DeSimone <[email protected]> > Cc: Star Zeng <[email protected]> > Cc: Kuo Ted <[email protected]> > Cc: Duggapu Chinni B <[email protected]> > Cc: Rangasai V Chaganty <[email protected]> > Cc: Digant H Solanki <[email protected]> > Cc: Sangeetha V <[email protected]> > > Signed-off-by: Ashraf Ali S <[email protected]> > --- > .../BaseFspDebugLibSerialPort.inf | 8 ++- > .../{Ia32 => }/FspDebug.nasm | 50 +++++++++---------- > 2 files changed, 28 insertions(+), 30 deletions(-) rename > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/{Ia32 => }/FspDebug.nasm > (86%) > > diff --git > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.i > nf > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.i > nf > index 14b1899e6c..0024edf2dc 100644 > --- > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort.i > nf > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSeri > +++ alPort.inf > @@ -1,7 +1,7 @@ > ## @file > # Instance of BaseFspDebugLib > # > -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR> > +# Copyright (c) 2014 - 2022, Intel Corporation. All rights > +reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -16,14 +16,12 @@ > LIBRARY_CLASS = DebugLib > > # > -# VALID_ARCHITECTURES = IA32 > +# VALID_ARCHITECTURES = IA32 X64 > # > > [Sources] > DebugLib.c > - > -[Sources.Ia32] > - Ia32/FspDebug.nasm > + FspDebug.nasm > > [Packages] > MdePkg/MdePkg.dec > diff --git > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.nasm > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/FspDebug.nasm > similarity index 86% > rename from > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.nasm > rename to IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/FspDebug.nasm > index 997e375c8c..ffacaa239d 100644 > --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/Ia32/FspDebug.nasm > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/FspDebug.nasm > @@ -1,25 +1,25 @@ > -;------------------------------------------------------------------------------ > -; > -; Copyright (c) 2016, Intel Corporation. All rights reserved.<BR> -; > SPDX-License- > Identifier: BSD-2-Clause-Patent -; -; Abstract: > -; > -; FSP Debug functions > -; > -;------------------------------------------------------------------------------ > - > - SECTION .text > - > -;------------------------------------------------------------------------------ > -; UINT32 * > -; EFIAPI > -; GetStackFramePointer ( > -; VOID > -; ); > -;------------------------------------------------------------------------------ > -global ASM_PFX(GetStackFramePointer) > -ASM_PFX(GetStackFramePointer): > - mov eax, ebp > - ret > - > +;---------------------------------------------------------------------- > +-------- > +; > +; Copyright (c) 2016 - 2022, Intel Corporation. All rights > +reserved.<BR> ; SPDX-License-Identifier: BSD-2-Clause-Patent ; ; > +Abstract: > +; > +; FSP Debug functions > +; > +;---------------------------------------------------------------------- > +-------- > + > + SECTION .text > + > +;---------------------------------------------------------------------- > +-------- > +; UINT32 * > +; EFIAPI > +; GetStackFramePointer ( > +; VOID > +; ); > +;---------------------------------------------------------------------- > +-------- > +global ASM_PFX(GetStackFramePointer) > +ASM_PFX(GetStackFramePointer): > + mov eax, ebp > + ret > + > -- > 2.30.2.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86846): https://edk2.groups.io/g/devel/message/86846 Mute This Topic: https://groups.io/mt/89116030/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
