Reviewed-by: Ray Ni <ray...@intel.com> -----Original Message----- From: Gao, Zhichao <zhichao....@intel.com> Sent: Tuesday, February 15, 2022 4:10 PM To: Rehan, MohammedX <mohammedx.re...@intel.com>; devel@edk2.groups.io; Esakkithevar, Kathappan <kathappan.esakkithe...@intel.com>; Ni, Ray <ray...@intel.com>; Pethaiyan, Madhan <madhan.pethai...@intel.com> Cc: Thirupugal, MadhaviX <madhavix.thirupu...@intel.com> Subject: RE: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure
Reviewed-by: Zhichao Gao <zhichao....@intel.com> Thanks, Zhichao > -----Original Message----- > From: Rehan, MohammedX <mohammedx.re...@intel.com> > Sent: Tuesday, February 15, 2022 4:07 PM > To: devel@edk2.groups.io; Esakkithevar, Kathappan > <kathappan.esakkithe...@intel.com>; Gao, Zhichao > <zhichao....@intel.com>; Ni, Ray <ray...@intel.com>; Pethaiyan, Madhan > <madhan.pethai...@intel.com> > Cc: Thirupugal, MadhaviX <madhavix.thirupu...@intel.com>; Rehan, > MohammedX <mohammedx.re...@intel.com> > Subject: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3819 > > Ping GetTimerPeriod API returns sometime zero value when StallCounter > has smaller value than RttTimerTick (divide by zero) which results > some failure at ping UEFI shell command > > Signed-off-by: MohammedX Rehan <mohammedx.re...@intel.com> > --- > ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > index ec1e0a188b..6a002b15e5 100644 > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > @@ -259,9 +259,11 @@ GetTimerPeriod ( > EFI_EVENT TimerEvent; UINT32 StallCounter; EFI_TPL OldTpl;+ > UINT32 TimerPeriod; RttTimerTick = 0; StallCounter = 0;+ > TimerPeriod = > 0; Status = gBS->CreateEvent ( EVT_TIMER | > EVT_NOTIFY_SIGNAL,@@ -295,7 +297,12 @@ GetTimerPeriod ( > gBS->SetTimer (TimerEvent, TimerCancel, 0); gBS->CloseEvent > (TimerEvent); - return StallCounter / RttTimerTick;+ TimerPeriod = > StallCounter / RttTimerTick;+ if (TimerPeriod != 0) {+ return > TimerPeriod;+ } > else {+ return 1;+ } } /**-- > 2.30.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86695): https://edk2.groups.io/g/devel/message/86695 Mute This Topic: https://groups.io/mt/89156648/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
