Hi > > > > Add PcdTdxWorkAreaBase to indicate the area of memory where the > > > > TDX work area block lives. > > > > > > Why have both PcdSevEsWorkAreaBase and PcdTdxWorkAreaBase when > we > > > have a shared work area? > > PcdTdxWorkAreaBase mimics PcdSevEsWorkAreaBase. Yes, > TdxWorkAreaBase is same as SevEsWorkAreaBase. But the name of > TdxWorkAreaBase is more meaningful in the Tdx related code. > > Yes, using PcdSevEsWorkAreaBase in TDX code would look somewhat odd, > but we can rename the PCD to have 'CC' in the name like we already did for > other bits shared between sev and tdx. > Agree that can we rename the PcdSevEsWorkAreaBase to PcdCcWorkAreaBase. Brijesh Singh is the owner of PcdSevEsWorkAreaBase. Brijesh, what's your thought about it?
I check the files which need be updated from PcdSevEsWorkAreaBase to PcdCcWorkAreaBase $ grep -rn --exclude-dir=Build PcdSevEsWorkAreaBase - UefiCpuPkg/Library/MpInitLib/AmdSev.c - UefiCpuPkg/Library/MpInitLib/MpLib.c - UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf - UefiCpuPkg/UefiCpuPkg.dec - UefiCpuPkg/UefiCpuPkg.uni - OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLibInternal.c - OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLib.inf - OvmfPkg/Sec/AmdSev.c - OvmfPkg/Sec/SecMain.inf - OvmfPkg/CloudHv/CloudHvX64.fdf - OvmfPkg/OvmfPkgX64.fdf - OvmfPkg/Microvm/MicrovmX64.fdf - OvmfPkg/ResetVector/ResetVector.inf - OvmfPkg/ResetVector/ResetVector.nasmb - OvmfPkg/AmdSev/AmdSevX64.fdf I would suggest Renaming PcdSevEsWorkAreaBase to PcdCcWorkAreaBase be in a separate patch-set. Gerd, What's your thought? Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86637): https://edk2.groups.io/g/devel/message/86637 Mute This Topic: https://groups.io/mt/88666800/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
