Current MM communicate2 function from ArmPkg described input arguments
`CommBufferPhysical`, `CommBufferVirtual` and `CommSize` as input only,
which mismatches with the "input and output type" as in PI specification.
This change updated function descriptions of MM communite2 to match input
argument types.
Cc: Leif Lindholm <l...@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
Cc: Bret Barkelew <bret.barke...@microsoft.com>
Cc: Michael Kubacki <michael.kuba...@microsoft.com>
Cc: Sami Mujawar <sami.muja...@arm.com>
Signed-off-by: Kun Qin <kuqi...@gmail.com>
Reviewed-by: Sami Mujawar <sami.muja...@arm.com>
---
Notes:
v2:
- Splitting patch into 1 of 4 [Ard]
v3:
- Added cc entry and reviewed-by tag [Sami]
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
index 7c8284104d87..7f756a32d4e0 100644
--- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
+++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
@@ -41,12 +41,13 @@ STATIC EFI_HANDLE mMmCommunicateHandle;
This function provides a service to send and receive messages from a
registered UEFI service.
- @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL instance.
- @param[in] CommBufferPhysical Physical address of the MM communication
buffer
- @param[in] CommBufferVirtual Virtual address of the MM communication buffer
- @param[in] CommSize The size of the data buffer being passed in.
On exit, the size of data
- being returned. Zero if the handler does not
wish to reply with any data.
- This parameter is optional and may be NULL.
+ @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL
instance.
+ @param[in, out] CommBufferPhysical Physical address of the MM communication
buffer
+ @param[in, out] CommBufferVirtual Virtual address of the MM communication
buffer
+ @param[in, out] CommSize The size of the data buffer being passed
in. On exit, the
+ size of data being returned. Zero if the
handler does not
+ wish to reply with any data. This
parameter is optional
+ and may be NULL.
@retval EFI_SUCCESS The message was successfully posted.
@retval EFI_INVALID_PARAMETER CommBufferPhysical was NULL or
CommBufferVirtual was NULL.
--
2.34.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86068): https://edk2.groups.io/g/devel/message/86068
Mute This Topic: https://groups.io/mt/88680222/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
