On Wed, Jan 05, 2022 at 06:35:06PM +0800, Maggie Chu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3757
>
> Add registers of boot partition feature which defined in NVM Express 1.4 Spec
nvme boot in qemu broke, and git bisect landed at this commit.
Error message:
NvmeControllerInit: the controller doesn't support NVMe command set
> // These register offsets are defined as 0x1000 + (N * (4 << CAP.DSTRD))
> @@ -51,11 +55,14 @@ typedef struct {
> UINT8 To; // Timeout
> UINT16 Dstrd : 4;
> UINT16 Nssrs : 1; // NVM Subsystem Reset Supported NSSRS
> - UINT16 Css : 4; // Command Sets Supported - Bit 37
> - UINT16 Rsvd3 : 7;
> + UINT16 Css : 8; // Command Sets Supported - Bit 37
> + UINT16 Bps : 1; // Boot Partition Support - Bit 45 in NVMe1.4
> + UINT16 Rsvd3 : 2;
This looks very suspicious ...
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85657): https://edk2.groups.io/g/devel/message/85657
Mute This Topic: https://groups.io/mt/88211217/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
