Reviewed-by: Nate DeSimone <nathaniel.l.desim...@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oram, > Isaac W > Sent: Tuesday, January 11, 2022 6:20 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W <isaac.w.o...@intel.com>; Chaganty, Rangasai V > <rangasai.v.chaga...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn> > Subject: [edk2-devel][edk2-platforms][PATCH V1 09/27] SmbiosFeaturePkg: > Use MinPlatformPkg build include files > > Use the MinPlatformPkg common core build files to build libraries needed by > this feature. > > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Signed-off-by: Isaac Oram <isaac.w.o...@intel.com> > --- > > Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemory > .fdf | 2 +- > > Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeatu > re.dsc | 52 -------------------- > > Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.ds > c | 18 +++++++ > 3 files changed, 19 insertions(+), 53 deletions(-) > > diff --git > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemo > ry.fdf > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMem > ory.fdf > index c3a3e81503..d46bacfbd2 100644 > --- > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemo > ry.fdf > +++ > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMem > o > +++ ry.fdf > @@ -7,4 +7,4 @@ > # > ## > > - INF SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasicDxe.inf > +INF SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasicDxe.inf > diff --git > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFea > ture.dsc > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFea > ture.dsc > index 094dd957b8..7a165f39d7 100644 > --- > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFea > ture.dsc > +++ > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFe > +++ ature.dsc > @@ -33,28 +33,6 @@ > > !include MdePkg/MdeLibs.dsc.inc > > -[LibraryClasses] > - ####################################### > - # Edk2 Packages > - ####################################### > - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > - > BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibR > epStr.inf > - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > - > UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo > otServicesTableLib.inf > - > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry > Point.inf > - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > - > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > /UefiRuntimeServicesTableLib.inf > - > -[LibraryClasses.common.DXE_DRIVER] > - ####################################### > - # Edk2 Packages > - ####################################### > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemo > ryAllocationLib.inf > - PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > - > > ########################################################## > ###################### > # > # Component section - list of all components that need built for this > feature. > @@ -69,21 +47,6 @@ > # generated for it, but the binary will not be put into any firmware > volume. > # > > ########################################################## > ###################### > -# > -# Feature PEI Components > -# > - > -# @todo: Change below line to [Components.$(PEI_ARCH)] after > https://bugzilla.tianocore.org/show_bug.cgi?id=2308 > -# is completed. > -[Components.IA32] > - ##################################### > - # SMBIOS Feature Package > - ##################################### > - > - # Add library instances here that are not included in package components > and should be tested > - # in the package build. > - > - # Add components here that should be included in the package build. > > # > # Feature DXE Components > @@ -101,18 +64,3 @@ > > # Add components here that should be included in the package build. > SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasicDxe.inf > - > - > ########################################################## > ######################################### > -# > -# BuildOptions Section - Define the module specific tool chain flags that > should be used as > -# the default flags for a module. These flags are > appended to any > -# standard flags that are defined by the build > process. They can > be > -# applied for any modules or only those modules with > the > specific > -# module style (EDK or EDKII) specified in > [Components] section. > -# > -# For advanced features, it is recommended to enable > [BuildOptions] in > -# the applicable INF file so it does not affect the > whole board > package > -# build when this DSC file is active. > -# > - > ########################################################## > ######################################### > -[BuildOptions] > diff --git > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg. > dsc > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg. > dsc > index 31141c0725..e72b341154 100644 > --- > a/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg. > dsc > +++ > b/Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg > +++ .dsc > @@ -24,6 +24,24 @@ > PEI_ARCH = IA32 > DXE_ARCH = X64 > > +[Packages] > + MinPlatformPkg/MinPlatformPkg.dec > + > +[PcdsFeatureFlag] > + # > + # PCD needed for MinPlatform build includes > + # > + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable > |FALSE > + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable > |FALSE > + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable > |FALSE > + > +# > +# Include common libraries > +# > +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc > + > # > # This package always builds the feature. > # > -- > 2.27.0.windows.1 > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85633): https://edk2.groups.io/g/devel/message/85633 Mute This Topic: https://groups.io/mt/88365338/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
