Hi Ross, This PR is showing CI failures with VS2019
https://dev.azure.com/tianocore/11ea4a10-ac9f-4e5f-8b13-7def1f19d478/_apis/build/builds/36559/logs/178 2021-12-23T00:53:44.7544282Z PROGRESS - Running Build DEBUG 2021-12-23T00:54:36.3840067Z ERROR - Compiler #2059 from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_string.h(67): syntax error: '(' 2021-12-23T00:54:36.3841683Z ERROR - Compiler #2146 from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_string.h(67): syntax error: missing ')' before identifier 'UINTN' 2021-12-23T00:54:36.3845453Z WARNING - Compiler #4029 from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_string.h(67): declared formal parameter list different from definition 2021-12-23T00:54:36.3847199Z ERROR - Compiler #2059 from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_string.h(67): syntax error: ')' 2021-12-23T00:54:36.3851318Z ERROR - Compiler #2059 from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_string.h(67): syntax error: '<parameter-list>' 2021-12-23T00:54:36.3853972Z WARNING - Compiler #4205 from C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt\corecrt_memcpy_s.h(45): nonstandard extension used: static function declaration in function scope 2021-12-23T00:54:36.3858517Z WARNING - Compiler #4020 from C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt\corecrt_memcpy_s.h(54): 'SetMem': too many actual parameters 2021-12-23T00:54:36.3861595Z WARNING - Compiler #4020 from d:\a\1\s\MdeModulePkg\Library\BrotliCustomDecompressLib\brotli\c\common\shared_dictionary.c(103): 'SetMem': too many actual parameters 2021-12-23T00:54:36.3864836Z WARNING - Compiler #4020 from d:\a\1\s\MdeModulePkg\Library\BrotliCustomDecompressLib\brotli\c\common\shared_dictionary.c(496): 'SetMem': too many actual parameters 2021-12-23T00:54:36.3867350Z ERROR - Compiler #1077 from NMAKE : fatal '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\Hostx86\x86\cl.exe"' : return code '0x2' 2021-12-23T00:54:36.3870885Z ERROR - Compiler #7000 from : Failed to execute command 2021-12-23T00:54:36.3873160Z ERROR - EDK2 #002 from : Failed to build module 2021-12-23T00:54:36.3878035Z CRITICAL - Build failed Can you please resolve and update the PR. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ross Burton > Sent: Thursday, December 23, 2021 2:02 AM > To: Gao, Liming <gaolim...@byosoft.com.cn> > Cc: Pedro Falcato <pedro.falc...@gmail.com>; edk2-devel-groups-io > <devel@edk2.groups.io>; Feng, Bob C <bob.c.f...@intel.com>; > Chen, Christine <yuwei.c...@intel.com> > Subject: Re: [edk2-devel] [PATCH] BaseTools/Brotli: update to latest brotli > submodule > > On Thu, 23 Dec 2021 at 00:48, gaoliming <gaolim...@byosoft.com.cn> wrote: > > Create PR https://github.com/tianocore/edk2/pull/2346 for this patch. > > There are now *three* PRs on GitHub to solve this issue, which is a > build breaker for anyone using a new GCC. > > Can someone please merge the fix? > > Ross > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85202): https://edk2.groups.io/g/devel/message/85202 Mute This Topic: https://groups.io/mt/87915616/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
