Hi, > I don't think this is very idiomatic for EDK2, and I wonder if it > would be better to use [fixed] PCDs for build time configuration, and > perhaps expose the other width/height data (and the associated policy > of what takes precedence over what) via a protocol instead.
Well, yes. Ideally we would just tag the resolution in the GOP protocol mode list, simliar to the linux kernel which has a DRM_MODE_TYPE_PREFERRED flag for that purpose. Problem is the GOP protocol doesn't support that ... It's also kind-of specific to virtual machines. On physical hardware just using the highest resolution available works just fine as that is typically the native display resolution. In a virtual machine you don't want come up with a huge 4k window by default just because the virtual vga is able to handle that. Cutting down the video mode list isn't a great solution either as that would also remove the modes from the platform configuration so the user wouldn't be able to pick a resolution higher than the default any more. > In general, I am not too keen on overusing PCDs for any of this, as it > does not have the implied dependency ordering that PPIs or protocols > have. Laszlo mentioned OvmfPkg has a less strict policy than the rest of edk2 for this kind of pcd usage. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85049): https://edk2.groups.io/g/devel/message/85049 Mute This Topic: https://groups.io/mt/87767746/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
