Hi > > On Mon, Dec 13, 2021 at 08:57:02PM +0800, Min Xu wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 > > > > OvmfPkg.dec is removed from [Packages] because it doesn't depend on > > OvmfPkg. LocalApicTimerDxe is moved to UefiCpuPkg. > > > if (mTimerNotifyFunction != NULL) { > > - // > > - // @bug : This does not handle missed timer interrupts > > - // > > mTimerNotifyFunction (mTimerPeriod); > > } > > > if (TimerPeriod == 0) { > > + // > > + // Stop the timer > > + // > > + InitializeApicTimer (0, 0, FALSE, LOCAL_APIC_TIMER_VECTOR); > > + > > This is more than a pure move. > Functional changes should be a separate patch. > > > TimerDriverGetTimerPeriod ( > > - IN EFI_TIMER_ARCH_PROTOCOL *This, > > - OUT UINT64 *TimerPeriod > > + IN EFI_TIMER_ARCH_PROTOCOL *This, > > + OUT UINT64 *TimerPeriod > > What's this? uncrustify? > Reformating should be a separate patch too. > Thanks for reminder. It will be in a separate patch.
Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84971): https://edk2.groups.io/g/devel/message/84971 Mute This Topic: https://groups.io/mt/87696613/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
