Hi Chandni,
Thank you for this patch.
I think the following change from "[edk2-platforms][PATCH V1 05/11]
Platform/ARM/Morello: Add initial support for Morello SoC" should be
part of this patch.
diff --git a/Platform/ARM/Morello/MorelloPlatform.dsc.inc
b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
index dccd22248318..862d5f2da1b0 100644
--- a/Platform/ARM/Morello/MorelloPlatform.dsc.inc
+++ b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
@@ -9,13 +9,13 @@
[LibraryClasses.common]
ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
-
ArmPlatformLib|Platform/ARM/Morello/Library/PlatformLib/PlatformLib.inf
BasePathLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
++ b/Platform/ARM/Morello/MorelloPlatformFvp.dsc
@@ -39,14 +39,18 @@
!include MdePkg/MdeLibs.dsc.inc
[LibraryClasses.common]
+ # Platform Library
+
ArmPlatformLib|Platform/ARM/Morello/Library/PlatformLib/PlatformLibFvp.inf
Can you update this accordingly, please?
With that changed,
Reviewed-by: Sami Mujawar <sami.muja...@arm.com>
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
PlatformLibMem.c file is going to be different for Morello
FVP and Morello SoC platforms since the virtual memory mapping
is different so the file PlatformLibMem.c is renamed as
PlatformLibMemFvp.c and PlatformLib.inf is renamed as
PlatformLibFvp.inf.
Signed-off-by: Chandni Cherukuri <chandni.cheruk...@arm.com>
---
Platform/ARM/Morello/Library/PlatformLib/{PlatformLib.inf =>
PlatformLibFvp.inf} | 4 ++--
Platform/ARM/Morello/Library/PlatformLib/{PlatformLibMem.c =>
PlatformLibMemFvp.c} | 0
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/ARM/Morello/Library/PlatformLib/PlatformLib.inf
b/Platform/ARM/Morello/Library/PlatformLib/PlatformLibFvp.inf
similarity index 91%
rename from Platform/ARM/Morello/Library/PlatformLib/PlatformLib.inf
rename to Platform/ARM/Morello/Library/PlatformLib/PlatformLibFvp.inf
index c2d7da3701d2..d4c8744c0954 100644
--- a/Platform/ARM/Morello/Library/PlatformLib/PlatformLib.inf
+++ b/Platform/ARM/Morello/Library/PlatformLib/PlatformLibFvp.inf
@@ -1,5 +1,5 @@
## @file
-# Platform Library for Morello platform.
+# Platform Library for Morello FVP platform.
#
# Copyright (c) 2021, ARM Limited. All rights reserved.<BR>
#
@@ -24,7 +24,7 @@
[Sources.common]
PlatformLib.c
- PlatformLibMem.c
+ PlatformLibMemFvp.c
[Sources.AARCH64]
AArch64/Helper.S | GCC
diff --git a/Platform/ARM/Morello/Library/PlatformLib/PlatformLibMem.c
b/Platform/ARM/Morello/Library/PlatformLib/PlatformLibMemFvp.c
similarity index 100%
rename from Platform/ARM/Morello/Library/PlatformLib/PlatformLibMem.c
rename to Platform/ARM/Morello/Library/PlatformLib/PlatformLibMemFvp.c
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84463): https://edk2.groups.io/g/devel/message/84463
Mute This Topic: https://groups.io/mt/87497019/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
