On Wed, 1 Dec 2021 at 03:45, Masahisa Kojima <masahisa.koj...@linaro.org> wrote: > > Hi Ard, > > Thank you for your review. > > On Tue, 30 Nov 2021 at 20:39, Ard Biesheuvel <a...@kernel.org> wrote: > > > > Hello Masahisa, > > > > Thanks for this patch. > > > > On Tue, 30 Nov 2021 at 09:37, Masahisa Kojima > > <masahisa.koj...@linaro.org> wrote: > > > > > > This commit adds the SMBIOS type 17 table support for Developerbox. > > > The SPD can be accessed only from the SCP through I2C bus, > > > so this commit expects that SCP-firmware reads the SPD and > > > stores it in the non-secure SRAM. > > > > > > > What happens if the existing SCP firmware does not populate this memory > > region? > > If no valid SPD is found, fill the default SMBIOS Type17 information, > it is same as > current implementation. > > > > > > This commit also reduces the edk2 stack size to allocate > > > the space for storing SPD. It requires 2KB, 512bytes * 4 DIMMs. > > > > > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > > Cc: Leif Lindholm <l...@nuviainc.com> > > > Cc: Masami Hiramatsu <masami.hirama...@linaro.org> > > > Signed-off-by: Masahisa Kojima <masahisa.koj...@linaro.org> > > > > It seems to me that this patch contains some pieces that are generic > > SPD handling, and could be broken out. I haven't checked, but perhaps > > some of this already exists in the tree? > > Some SPD handling can be generic. > For example, HiSilicon platform has almost same JEP106_MANUFACTURER_TABLE > table. > But most of the processing are platform specific in my check, no platform > except > for Developerbox accesses the raw SPD to construct the SMBIOS type17 table. >
OK, fair enough. Pushed as e9149e2c1b54..c718abce99a1 -- Ard. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84243): https://edk2.groups.io/g/devel/message/84243 Mute This Topic: https://groups.io/mt/87398626/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
