Gerd, thanks. I am about to raise the same comments...
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd Hoffmann
Sent: Wednesday, November 3, 2021 3:00 PM
To: Xu, Min M <min.m...@intel.com>
Cc: devel@edk2.groups.io; Brijesh Singh <brijesh.si...@amd.com>; Erdem Aktas
<erdemak...@google.com>; James Bottomley <j...@linux.ibm.com>; Yao, Jiewen
<jiewen....@intel.com>; Tom Lendacky <thomas.lenda...@amd.com>; Dong, Eric
<eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Kumar, Rahul1
<rahul1.ku...@intel.com>
Subject: Re: [edk2-devel] [PATCH V3 23/29] UefiCpuPkg: Update AddressEncMask in
CpuPageTable
Hi,
> + gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask ##
> CONSUMES
> AddressEncMask = PcdGet64 (PcdPteMemoryEncryptionAddressOrMask) &
> PAGING_1G_ADDRESS_MASK_64;
> + if (AddressEncMask == 0) {
> + AddressEncMask = PcdGet64 (PcdTdxSharedBitMask) &
> + PAGING_1G_ADDRESS_MASK_64; }
Looks like two PCDs for basically the same thing.
Should we create a common CC PCD here?
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83906): https://edk2.groups.io/g/devel/message/83906
Mute This Topic: https://groups.io/mt/86739889/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
