On 09/11/2021 08:40, Gerd Hoffmann wrote:
3. Require use of uncrustify tool before submitting patch review emails or PRs. * The required version would be a formally released version from the fork maintained by Michael Kubacki until the changes can be upstreamed. * https://dev.azure.com/projectmu/UncrustifyCan we please *first* get the changes merged to upstream uncrustify? That'll make the whole process much less painful because the usual software repositories (linux distro packages, macos homebrew, ...) can be used to install uncrustify then, and it's also less confusing if developers don't have to juggle with different uncrustify variants (upstream vs. edk2).
I very strongly agree with this. It's always a bad sign when a project requires installation of a custom version of a widely used tool.
Michael -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83505): https://edk2.groups.io/g/devel/message/83505 Mute This Topic: https://groups.io/mt/84932137/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
