Reviewed-by: Nate DeSimone <nathaniel.l.desim...@intel.com> -----Original Message----- From: mikub...@linux.microsoft.com <mikub...@linux.microsoft.com> Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Agyeman, Prince <prince.agye...@intel.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> Subject: [PATCH v6 49/52] SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol
From: Michael Kubacki <michael.kuba...@microsoft.com> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates references to the "PCH_SPI_PROTOCOL" to instead refer to "PCH_SPI2_PROTOCOL". Cc: Agyeman Prince <prince.agye...@intel.com> Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> --- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c | 8 ++++---- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h | 2 +- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c b/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c index e4a81f91316c..19f1cb92c921 100644 --- a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c +++ b/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c @@ -29,8 +29,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED UINT32 mSpiResvMmioAddr; - Documented in System Management Mode Core Interface Specification . - @result - The SPI SMM driver produces @link _PCH_SPI_PROTOCOL PCH_SPI_PROTOCOL @endlink with GUID - gPchSmmSpiProtocolGuid which is different from SPI RUNTIME driver. + The SPI SMM driver produces @link _PCH_SPI2_PROTOCOL PCH_SPI2_PROTOCOL @endlink with GUID + gPchSmmSpi2ProtocolGuid which is different from SPI RUNTIME driver. - <b>Integration Check List</b>\n - This driver supports Descriptor Mode only. @@ -92,11 +92,11 @@ InstallPchSpi ( return Status; } // - // Install the SMM PCH_SPI_PROTOCOL interface + // Install the SMM PCH_SPI2_PROTOCOL interface // Status = gSmst->SmmInstallProtocolInterface ( &(mSpiInstance->Handle), - &gPchSmmSpiProtocolGuid, + &gPchSmmSpi2ProtocolGuid, EFI_NATIVE_INTERFACE, &(mSpiInstance->SpiProtocol) ); diff --git a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h b/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h index 6ada9b121d92..68388319da17 100644 --- a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h +++ b/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h @@ -17,7 +17,7 @@ #include <Library/BaseMemoryLib.h> #include <Library/SmmServicesTableLib.h> #include <PchAccess.h> -#include <Protocol/Spi.h> +#include <Protocol/Spi2.h> #include <IncludePrivate/Library/PchSpiCommonLib.h> #endif diff --git a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf b/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf index 35655ed5b5aa..12a21dc57a9b 100644 --- a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf +++ b/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf @@ -37,7 +37,7 @@ [Sources] [Protocols] - gPchSmmSpiProtocolGuid # PRODUCES + gPchSmmSpi2ProtocolGuid # PRODUCES [Depex] -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83192): https://edk2.groups.io/g/devel/message/83192 Mute This Topic: https://groups.io/mt/86664079/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-