Hi, > Do you think it should so generic that it can remove OvmfPkg dependency and > be moved to UefiCpuPkg?
It's not fully standalone, the driver needs to know the lapic frequency (that is the reason why PcdFSBClock exists). For KVM this is easy, the lapic uses a fixed frequency so it can simply be set in the .dsc file. For Xen the lapic frequency is the same as the tsc frequency, so the xen code (platform init I think) goes figure the tsc freq and sets PcdFSBClock accordingly. So, when you want use the driver elsewhere you need to fill that gap, and there is little reason to go that extra mile because on physical hardware you have other options like using the hpet timer. [ qemu supports hpet emulation but it is disabled by default for performance reasons, other timers have less virtualization overhead. ] I'd suggest to keep it in OvmfPkg. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83118): https://edk2.groups.io/g/devel/message/83118 Mute This Topic: https://groups.io/mt/86735078/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
