Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > -----邮件原件----- > 发件人: Michael D Kinney <michael.d.kin...@intel.com> > 发送时间: 2021年11月2日 1:45 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng <bob.c.f...@intel.com>; Liming Gao > <gaolim...@byosoft.com.cn>; Yuwei Chen <yuwei.c...@intel.com> > 主题: [Patch 1/1] BaseTools/VrfCompile: Fix uninitialized field from unnamed > field > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3687 > > If a C structure parsed by the VFR compiler contains an unnamed > field, then mFieldName is left uninitialized, which generates > random data in the VFR compiler output file. > > If the FieldName is NULL, then initialize pNewField->mFieldName > to a Null-terminated empty string. > > Cc: Bob Feng <bob.c.f...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Yuwei Chen <yuwei.c...@intel.com> > Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> > --- > BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp > b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp > index 2b9b5dbb1ca5..11470de45cce 100644 > --- a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp > +++ b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp > @@ -1135,6 +1135,8 @@ CVfrVarDataTypeDB::DataTypeAddBitField ( > if (FieldName != NULL) { > strncpy (pNewField->mFieldName, FieldName, MAX_NAME_LEN - 1); > pNewField->mFieldName[MAX_NAME_LEN - 1] = 0; > + } else { > + strncpy (pNewField->mFieldName, "", MAX_NAME_LEN - 1); > } > pNewField->mFieldType = pFieldType; > pNewField->mIsBitField = TRUE; > @@ -3916,5 +3918,3 @@ CVfrStringDB::GetUnicodeStringTextSize ( > CVfrVarDataTypeDB gCVfrVarDataTypeDB; > CVfrDefaultStore gCVfrDefaultStore; > CVfrDataStorage gCVfrDataStorage; > - > - > -- > 2.32.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83073): https://edk2.groups.io/g/devel/message/83073 Mute This Topic: https://groups.io/mt/86757261/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
