Hi Gerd I tend to agree with you on the direction to use one TEE specific Exception lib.
However, I have naming concern. The VMG is very SEV specific term. I don't believe it is a right name to cover the TEE exception lib. If Brijesh agree to merge, I think we should rename it to a neutral name, such as TeeExitLib. What do you think, Brijesh? Thank you Yao Jiewen > -----Original Message----- > From: kra...@redhat.com <kra...@redhat.com> > Sent: Wednesday, October 27, 2021 3:20 PM > To: Xu, Min M <min.m...@intel.com> > Cc: Brijesh Singh <brijesh.si...@amd.com>; Yao, Jiewen > <jiewen....@intel.com>; devel@edk2.groups.io; Erdem Aktas > <erdemak...@google.com>; James Bottomley <j...@linux.ibm.com>; Tom > Lendacky <thomas.lenda...@amd.com>; Dong, Eric <eric.d...@intel.com>; Ni, > Ray <ray...@intel.com>; Kumar, Rahul1 <rahul1.ku...@intel.com> > Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: > Add base support for the #VE exception > > Hi, > > > > How about adding the tdx exception handler to the existing library, so we > don't > > > have the churn of adding a new library everywhere *again*? > > > Do you mean add the VmTdExitVeHandler.c/VmTdExitLibNull.c in > CpuExceptionHandlerLib, then include the corresponding source file in each > *CpuExceptionHandlerLib.inf? > > No, I mean extend the existing VmgExitLib instead of adding a new > VmTdExitLib, i.e. place the tdx handler in > OvmfPkg/Library/VmgExitLib/TdxExitHandler.c > > take care, > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82783): https://edk2.groups.io/g/devel/message/82783 Mute This Topic: https://groups.io/mt/86085742/21656 Mute #ve:https://edk2.groups.io/g/devel/mutehashtag/ve Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
