Hi Gerd
I tend to agree with you on the direction to use one TEE specific Exception lib.

However, I have naming concern.
The VMG is very SEV specific term. I don't believe it is a right name to cover 
the TEE exception lib.

If Brijesh agree to merge, I think we should rename it to a neutral name, such 
as TeeExitLib.

What do you think, Brijesh?

Thank you
Yao Jiewen


> -----Original Message-----
> From: [email protected] <[email protected]>
> Sent: Wednesday, October 27, 2021 3:20 PM
> To: Xu, Min M <[email protected]>
> Cc: Brijesh Singh <[email protected]>; Yao, Jiewen
> <[email protected]>; [email protected]; Erdem Aktas
> <[email protected]>; James Bottomley <[email protected]>; Tom
> Lendacky <[email protected]>; Dong, Eric <[email protected]>; Ni,
> Ray <[email protected]>; Kumar, Rahul1 <[email protected]>
> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler:
> Add base support for the #VE exception
> 
>   Hi,
> 
> > > How about adding the tdx exception handler to the existing library, so we
> don't
> > > have the churn of adding a new library everywhere *again*?
> 
> > Do you mean add the VmTdExitVeHandler.c/VmTdExitLibNull.c in
> CpuExceptionHandlerLib, then include the corresponding source file in each
> *CpuExceptionHandlerLib.inf?
> 
> No, I mean extend the existing VmgExitLib instead of adding a new
> VmTdExitLib, i.e. place the tdx handler in
> OvmfPkg/Library/VmgExitLib/TdxExitHandler.c
> 
> take care,
>   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82783): https://edk2.groups.io/g/devel/message/82783
Mute This Topic: https://groups.io/mt/86085742/21656
Mute #ve:https://edk2.groups.io/g/devel/mutehashtag/ve
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to