I have incorporated all the review comments and suggestions
on v2 patches.
1) Was able to successfully run the CI on edk2-platforms enabled by Pierre
https://github.com/PierreARM/edk2-platforms/tree/review/N1Sdp_v2
2) Observed three false positive for Dependency Check
N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
depends on pkg Platform/ARM/N1Sdp/N1SdpPlatform.dec
N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
depends on pkg Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec
N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf depends on pkg
Platform/ARM/N1Sdp/N1SdpPlatform.dec
3) Duplicate GUIDs were fixed.
4) Coding style and doxygen related issues were fixed.
5) The build successfully boots on N1SDP in both multi and single chip profiles.
This patch series implements the configuration manager for N1Sdp
platform. It enables support for generating the following
ACPI tables:
1. FACP
2. DSDT
3. GTDT
4. APIC
5. SPCR
6. DBG2
7. PPTT
8. IORT
9. MCFG
10. SSDT - PCI
11. SSDT - REMOTE PCI
The changes can be seen at:
https://github.com/khasim/edk2-platforms-n1sdp/tree/n1sdp-upstream
Khasim Syed Mohammed (7):
Silicon/ARM/NeoverseN1Soc: Fix missing function documentation
Silicon/ARM/NeoverseN1Soc: Define new PCDs and configure memory map
Platform/ARM/N1Sdp: Introduce platform DXE driver
Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations
Platform/ARM/N1Sdp: Introduce platform specific asl tables
Platform/ARM/N1Sdp: Configuration Manager for N1Sdp
Platform/ARM/N1Sdp: Enable ACPI tables and configuration manager
.../AslTables/Dsdt.asl | 482 ++++
.../AslTables/SsdtPci.asl | 252 ++
.../AslTables/SsdtRemotePci.asl | 161 ++
.../ConfigurationManager.c | 2199 +++++++++++++++++
.../ConfigurationManager.h | 307 +++
.../ConfigurationManagerDxe.inf | 166 ++
.../ConfigurationManagerDxe/Hmat.c | 103 +
.../ConfigurationManagerDxe/Platform.h | 92 +
.../N1Sdp/Drivers/PlatformDxe/PlatformDxe.c | 59 +
.../N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf | 47 +
Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h | 35 +
Platform/ARM/N1Sdp/N1SdpPlatform.dec | 99 +
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 47 +-
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 22 +-
.../Library/PlatformLib/PlatformLib.c | 46 +-
.../Library/PlatformLib/PlatformLib.inf | 28 +-
.../Library/PlatformLib/PlatformLibMem.c | 84 +-
Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec | 35 +-
18 files changed, 4233 insertions(+), 31 deletions(-)
create mode 100644
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl
create mode 100644
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
create mode 100644
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtRemotePci.asl
create mode 100644
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
create mode 100644
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
create mode 100644
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
create mode 100644
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/Hmat.c
create mode 100644
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/Platform.h
create mode 100644 Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.c
create mode 100644 Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf
create mode 100644 Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h
create mode 100644 Platform/ARM/N1Sdp/N1SdpPlatform.dec
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82708): https://edk2.groups.io/g/devel/message/82708
Mute This Topic: https://groups.io/mt/86608841/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
