On October 23, 2021 12:14 PM, Brijesh Singh wrote:
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
> 
> While initializing APs, the MpInitLib may need to know whether the guest is
> running with active AMD SEV or Intel TDX memory encryption.
> 
> Add a new ConfidentialComputingGuestAttr PCD that can be used to query the
> memory encryption attribute.
> 
> ---
>  MdePkg/MdePkg.dec                             |  4 +++
>  .../Include/ConfidentialComputingGuestAttr.h  | 25 +++++++++++++++++++
>  2 files changed, 29 insertions(+)
>  create mode 100644 MdePkg/Include/ConfidentialComputingGuestAttr.h
> 
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> 8b18415b107a..cd903c35d2ff 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -2396,5 +2396,9 @@ [PcdsFixedAtBuild, PcdsPatchableInModule,
> PcdsDynamic, PcdsDynamicEx]
>    # @Prompt FSB Clock.
>    gEfiMdePkgTokenSpaceGuid.PcdFSBClock|200000000|UINT32|0x0000000c
> 
> +  ## This dynamic PCD indicates the memory encryption attribute of the guest.
> +  # @Prompt Memory encryption attribute
> +
> gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0|UINT64|0x
> + 0000002e
> +
This PCD is defined in MdePkg, but the title is " UefiCpuPkg: Define 
ConfidentialComputingGuestAttr". A typo ?

BTW, can you add below macro in the ConfidentialComputingGuestAttr.h, such as:
#define CC_GUEST_IS_TDX(x)   ((x) == CCAttrIntelTdx)
#define CC_GUEST_IS_SEV(x)   ((x) == CCAttrAmdSev || (x) == CCAttrAmdSevEs || 
(x) == CCAttrAmdSevSnp)

Thanks.
Min


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82619): https://edk2.groups.io/g/devel/message/82619
Mute This Topic: https://groups.io/mt/86530733/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to