On October 12, 2021 11:27 PM, Sami Mujawar wrote: > Hi Min, > > Thank you for this patch. > > I think it would greatly help if the EFI_TD_PROTOCOL is changed to something > more architecture neutral. As I understand, this patch series is removing the > dependency on TPM for measurement and is instead providing a lightweight > interface for extending measurements for Confidential Compute Architecture > (CCA) guests. > > Considering this, it would be good to generalise EFI_TD_PROTOCOL as a > Confidential Compute Architecture Measurement (CCAM) protocol. > In fact, your v2 series demonstrates this need with the introduction of > MEASURE_BOOT_PROTOCOLS in "[PATCH V2 2/3] SecurityPkg: Support > TdProtocol in DxeTpm2MeasureBootLib > [https://edk2.groups.io/g/devel/message/81651]";. > > As it stands, I feel most of the code can be reused/common. Some interfaces > may need to use an architecture specific library, and some configuration > options would need to be defined using PCDs. > > Kindly let me know your thoughts. > Thanks for your comments. Let me first discuss your feedback with our architecture. We will reply to your proposal a bit later.
Thanks. Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81945): https://edk2.groups.io/g/devel/message/81945 Mute This Topic: https://groups.io/mt/86163957/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
