On 10/12/21 5:58 PM, Xu, Min M wrote: > On October 12, 2021 9:23 PM, Lendacky Thomas wrote: >> On 10/11/21 9:37 PM, Min Xu wrote: >>> diff --git a/OvmfPkg/ResetVector/Main.asm >>> b/OvmfPkg/ResetVector/Main.asm index ae90a148fce7..a501fbe880f2 >> 100644 >>> --- a/OvmfPkg/ResetVector/Main.asm >>> +++ b/OvmfPkg/ResetVector/Main.asm >>> @@ -36,6 +36,14 @@ Main16: >>> >>> BITS 32 >>> >>> +%ifdef ARCH_X64 >> A regular SEV guest can be built in the hybrid IA32 and X64 configuration, >> so this >> will break existing SEV firmwares built in that manner. Only SEV-ES and >> SEV-SNP >> require the full X64 confguration. >> > WORK_AREA_GUEST_TYPE is defined in > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FOvmfPkg%2FResetVector%2FResetVector.nasmb%23L75&data=04%7C01%7Cbrijesh.singh%40amd.com%7C10fd025cc9324fe76a0808d98de49924%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637696835234415070%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=y7cujCXYfhvORki5aNbLF9Eq3BBrcfHykvlWFcYAciI%3D&reserved=0 > and previously it was cleared in > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FOvmfPkg%2FResetVector%2FIa32%2FPageTables64.asm%23L47&data=04%7C01%7Cbrijesh.singh%40amd.com%7C10fd025cc9324fe76a0808d98de49924%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637696835234425063%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=AQLw4AJ%2FFxoGjfT6arKFSTvkCshRMz1v5RLZOnA8p4A%3D&reserved=0. > These 2 lines are both surrounded by ARCH_X64. > So in this commit, the clearance of WORK_AREA_GUEST_TYPE in Main.asm is > surrounded by ARCH_X64 too. > Brijesh, what's your comments on this change?
Good point Tom. The WORK_AREA_GUEST_TYPE define should be moved outside the ARCH_X86. I missed it mainly because we renamed the ESWorkArea to Generic workarea but EsWorkArea was defined in ARCH_X86 only. Min, I can send a patch to move define outside the ARCH_X64 and then you can align the TDX code accordingly. > Thanks! > Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81888): https://edk2.groups.io/g/devel/message/81888 Mute This Topic: https://groups.io/mt/86253724/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
