HI Michael, The actual changes are fine. A couple of comments on the patch format.
* It's good to include the repository and package name, in the subject line [Repo Name: [Optional] Patch Version# #/total #] PackageName: <One line summary of the change> * Commit message is missing the BugZilla reference. * CC maintainers as part of the patch mail. You can get more details on these guidelines here<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process>. Regards, Sai From: Holland, Michael <michael.holl...@intel.com> Sent: Tuesday, September 28, 2021 7:15 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Ni, Ray <ray...@intel.com> Subject: [PATCH] Define FIT 4 record -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81717): https://edk2.groups.io/g/devel/message/81717 Mute This Topic: https://groups.io/mt/85940948/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
