Create a PR https://github.com/tianocore/edk2/pull/2030
-----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng Sent: Wednesday, September 29, 2021 7:44 PM To: pierre.gond...@arm.com; devel@edk2.groups.io; Liming Gao <gaolim...@byosoft.com.cn>; Sami Mujawar <sami.muja...@arm.com> Subject: Re: [edk2-devel] [PATCH v1 0/4] Set default Makefile name Reviewed-by: Bob Feng <bob.c.f...@intel.com> -----Original Message----- From: pierre.gond...@arm.com <pierre.gond...@arm.com> Sent: Thursday, September 23, 2021 4:59 PM To: devel@edk2.groups.io; Feng, Bob C <bob.c.f...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; Sami Mujawar <sami.muja...@arm.com> Subject: [PATCH v1 0/4] Set default Makefile name From: Pierre Gondois <pierre.gond...@arm.com> A Makefile name is not set in BaseTools when only building modules or libraries. This patch-set sets a default Makefile name for the "build" command. The patch-set also: - Removes unsused Makefile variables - Removes hard-coded references to "target.txt" and "tools_def.txt" The changes can be seen at: https://github.com/PierreARM/edk2/tree/1868_BaseTools_build_py_corrections_v1 Pierre Gondois (4): BaseTools/GenMake: Use ToolDefinition as fallback option BaseTools/build: Set MakefileName BaseTools: Remove Makefile/MakefileName fields BaseTools: Remove hard-coded strings for target and tools_def BaseTools/Source/Python/AutoGen/GenMake.py | 8 ++++---- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 1 - BaseTools/Source/Python/GenFds/GenFds.py | 4 ++-- .../Source/Python/GenFds/GenFdsGlobalVariable.py | 4 ++-- BaseTools/Source/Python/TargetTool/TargetTool.py | 3 ++- BaseTools/Source/Python/Workspace/BuildClassObject.py | 2 -- BaseTools/Source/Python/Workspace/DscBuildData.py | 9 ++++----- BaseTools/Source/Python/build/build.py | 11 ++++------- 8 files changed, 18 insertions(+), 24 deletions(-) -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81280): https://edk2.groups.io/g/devel/message/81280 Mute This Topic: https://groups.io/mt/85809767/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
