Daniel: We should try to keep single patch in one package. For this patch set, patch 3 depends on patch 2, every patch doesn't break the platform. So, I agree to keep them as the separate one.
Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Daniel > Schaefer > 发送时间: 2021年9月29日 7:11 > 收件人: Abner Chang <abner.ch...@hpe.com>; devel@edk2.groups.io > 抄送: Michael D Kinney <michael.d.kin...@intel.com>; Liming Gao > <gaolim...@byosoft.com.cn>; Zhiguang Liu <zhiguang....@intel.com>; Ard > Biesheuvel <ardb+tianoc...@kernel.org>; Leif Lindholm <l...@nuviainc.com>; > Sami Mujawar <sami.muja...@arm.com>; Gerd Hoffmann > <kra...@redhat.com>; Sunil V L <suni...@ventanamicro.com> > 主题: Re: [edk2-devel] [PATCH V2 2/9] MdePkg: Add PcdPciIoTranslation PCD > > I think it would make sense to combine this patch with > 3/9 ArmPkg: Use PcdPciIoTranslation PCD from MdePkg > > It's pointless by itself. > > On 9/28/21 16:31, Abner Chang wrote: > > This PCD is moved from ArmPkg that is used to set the base address > > of PCI MMIO window that provides I/O access. We relocate this PCD > > because this PCD is common to ARM and RSIC-V arch. > > > > Signed-off-by: Abner Chang <abner.ch...@hpe.com> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Zhiguang Liu <zhiguang....@intel.com> > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > Cc: Leif Lindholm <l...@nuviainc.com> > > Cc: Sami Mujawar <sami.muja...@arm.com> > > Cc: Gerd Hoffmann <kra...@redhat.com> > > Cc: Daniel Schaefer <daniel.schae...@hpe.com> > > Cc: Sunil V L <suni...@ventanamicro.com> > > --- > > MdePkg/MdePkg.dec | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > > index a28a2daaff..08d259764a 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -2302,6 +2302,10 @@ > > # @Prompt PCI Express Base Address. > > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000|UINT64 > |0x0000000a > > > > + ## This value is used to set the base address of PCI MMIO window that > provides I/O access. > > + # @Prompt PCI I/O Memory Map Window Base Address. > > + > gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x0|UINT64|0x00000040 > > + > > ## This value is used to set the size of PCI express hierarchy. The > default is 256 MB. > > # @Prompt PCI Express Base Size. > > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0x10000000|UINT64|0x > 0000000f > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81252): https://edk2.groups.io/g/devel/message/81252 Mute This Topic: https://groups.io/mt/85939274/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
