Hi Stefan,

This patch looks good to me.

Reviewed-by: Sami Mujawar <sami.muja...@arm.com>

Regards,

Sami Mujawar

On 22/09/2021, 17:32, "Stefan Berger" <stef...@linux.ibm.com> wrote:

    From: Stefan Berger <stef...@linux.vnet.ibm.com>

    Add a NULL implementation of the library class TpmPlatformHierarchyLib.

    Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3510
    Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
    Cc: Leif Lindholm <l...@nuviainc.com>
    Cc: Sami Mujawar <sami.muja...@arm.com>
    Cc: Gerd Hoffmann <kra...@redhat.com>
    Signed-off-by: Stefan Berger <stef...@linux.ibm.com>
    ---
     .../PeiDxeTpmPlatformHierarchyLib.c           | 22 +++++++++++++
     .../PeiDxeTpmPlatformHierarchyLib.inf         | 31 +++++++++++++++++++
     SecurityPkg/SecurityPkg.dsc                   |  1 +
     3 files changed, 54 insertions(+)
     create mode 100644 
SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c
     create mode 100644 
SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf

    diff --git 
a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c
 
b/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c
    new file mode 100644
    index 0000000000..dfc8863830
    --- /dev/null
    +++ 
b/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.c
    @@ -0,0 +1,22 @@
    +/** @file

    +    Null TPM Platform Hierarchy configuration library.

    +

    +    This library provides stub functions for customizing the TPM's 
Platform Hierarchy.

    +

    +    Copyright (c) 2021, IBM Corporation.

    +    SPDX-License-Identifier: BSD-2-Clause-Patent

    +

    +**/

    +

    +#include <Uefi.h>

    +

    +/**

    +  A NULL implementation of ConfigureTpmPlatformHierarchy.

    +**/

    +VOID

    +EFIAPI

    +ConfigureTpmPlatformHierarchy (

    +  )

    +{

    +  /* do nothing */

    +}

    diff --git 
a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf
 
b/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf
    new file mode 100644
    index 0000000000..1b1e9ad592
    --- /dev/null
    +++ 
b/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf
    @@ -0,0 +1,31 @@
    +### @file

    +#   NULL TPM Platform Hierarchy configuration library.

    +#

    +#   This library provides functions for customizing the TPM's Platform 
Hierarchy

    +#   Authorization Value (platformAuth) and Platform Hierarchy Authorization

    +#   Policy (platformPolicy) can be defined through this function.

    +#

    +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>

    +# Copyright (c) Microsoft Corporation.<BR>

    +#

    +# SPDX-License-Identifier: BSD-2-Clause-Patent

    +#

    +###

    +

    +[Defines]

    +  INF_VERSION                    = 1.27

    +  BASE_NAME                      = BasePlatform

    +  FILE_GUID                      = 8947A3F2-BfB4-45EF-968D-5C40C1CE6A58

    +  MODULE_TYPE                    = BASE

    +  VERSION_STRING                 = 1.0

    +  LIBRARY_CLASS                  = TpmPlatformHierarchyLib|PEIM DXE_DRIVER

    +

    +[LibraryClasses]

    +  BaseLib

    +

    +[Packages]

    +  MdePkg/MdePkg.dec

    +  SecurityPkg/SecurityPkg.dec

    +

    +[Sources]

    +  PeiDxeTpmPlatformHierarchyLib.c

    diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
    index f1f678c492..37318c64c5 100644
    --- a/SecurityPkg/SecurityPkg.dsc
    +++ b/SecurityPkg/SecurityPkg.dsc
    @@ -232,6 +232,7 @@
       SecurityPkg/Library/HashLibTpm2/HashLibTpm2.inf



       
SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf

    +  
SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHierarchyLib.inf



       #

       # TCG Storage.

    -- 
    2.31.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81046): https://edk2.groups.io/g/devel/message/81046
Mute This Topic: https://groups.io/mt/85794143/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to