Not just an improvement, but an actual bugfix.
I would propose a subject line change though:
Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math
->
Platform/Qemu: fix SbsaQemu DSDT format version
If you're OK with the change, I can fold that in.
Reviewed-by: Leif Lindholm <l...@nuviainc.com>
On Wed, Sep 22, 2021 at 16:37:09 -0600, Rebecca Cran wrote:
> Set the DSDT revision value to 2 by using the define from Acpi60.h
> EFI_ACPI_6_0_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_REVISION. This
> causes the AML interpreter to use full 64-bit integers and math.
>
> Signed-off-by: Rebecca Cran <rebe...@nuviainc.com>
> ---
> Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> index e056d6cdb02e..1bf9fbb99e75 100644
> --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> @@ -6,6 +6,7 @@
> * SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> +#include <IndustryStandard/Acpi60.h>
> #include <IndustryStandard/SbsaQemuAcpi.h>
>
> #define LINK_DEVICE(Uid, LinkName, Irq)
> \
> @@ -25,8 +26,9 @@
> Address, Pin, Link, Zero
> \
> }
>
> -DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "LINARO", "SBSAQEMU",
> - FixedPcdGet32 (PcdAcpiDefaultOemRevision)) {
> +DefinitionBlock ("DsdtTable.aml", "DSDT",
> +
> EFI_ACPI_6_0_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_REVISION,
> + "LINARO", "SBSAQEMU", FixedPcdGet32
> (PcdAcpiDefaultOemRevision)) {
> Scope (_SB) {
> // UART PL011
> Device (COM0) {
> --
> 2.31.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81027): https://edk2.groups.io/g/devel/message/81027
Mute This Topic: https://groups.io/mt/85802081/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
