> -----Original Message----- > From: gaoliming [mailto:gaolim...@byosoft.com.cn] > Sent: Tuesday, September 7, 2021 9:09 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > <abner.ch...@hpe.com>; 'Gerd Hoffmann' <kra...@redhat.com>; 'Ard > Biesheuvel' <a...@kernel.org> > Cc: 'Yao, Jiewen' <jiewen....@intel.com>; 'Ard Biesheuvel' > <ard.biesheu...@arm.com>; 'Kinney, Michael D' > <michael.d.kin...@intel.com>; 'Leif Lindholm' <l...@nuviainc.com>; 'Ni, Ray' > <ray...@intel.com>; Schaefer, Daniel <daniel.schae...@hpe.com>; 'Sunil V L' > <suni...@ventanamicro.com>; 'Ard Biesheuvel' <ardb+tianoc...@kernel.org> > Subject: 回复: [edk2-devel] [RFC] RISC-V QEMU virtual package > > Abner: > I prefer to use git mv command to move those modules from ArmVirtPkg to > OvmfPkg. This way can still keep git history for those modules. Yeah sure, this is much better. > > You can create the second patch to update ArmVirtPkg DSC/FDF, or > combine > this change into the first patch. I will just send two patches for ArmVirtPkg changes, then have the separate patch set for RiscvVirtPkg.
Thanks Abner > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Abner > Chang > > 发送时间: 2021年9月6日 21:05 > > 收件人: Gerd Hoffmann <kra...@redhat.com>; Ard Biesheuvel > > <a...@kernel.org> > > 抄送: Yao, Jiewen <jiewen....@intel.com>; devel@edk2.groups.io; > gaoliming > > <gaolim...@byosoft.com.cn>; Ard Biesheuvel <ard.biesheu...@arm.com>; > > Kinney, Michael D <michael.d.kin...@intel.com>; Leif Lindholm > > <l...@nuviainc.com>; Ni, Ray <ray...@intel.com>; Schaefer, Daniel > > <daniel.schae...@hpe.com>; Sunil V L <suni...@ventanamicro.com>; Ard > > Biesheuvel <ardb+tianoc...@kernel.org> > > 主题: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > Ok thanks, do we need the two steps to migrate FDT modules under > > OvmfPkg/? > > 1. One patch set to clone those modules under OvmfPkg/ > > 2. One patch set of ArmVirtPkg change to use those modules and deletes > the > > ones under ArmVirtPkg/. > > > > Or we just do all at once? I prefer to have two steps. How do you think? > > > > Another question, who would like to be the reviewers of OvmfPkg/Fdt/*? > Any > > volunteers from CC list? > > > > Thanks > > Abner > > > > > -----Original Message----- > > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > > Sent: Monday, September 6, 2021 8:19 PM > > > To: Ard Biesheuvel <a...@kernel.org> > > > Cc: Yao, Jiewen <jiewen....@intel.com>; Chang, Abner (HPS SW/FW > > > Technologist) <abner.ch...@hpe.com>; devel@edk2.groups.io; > gaoliming > > > <gaolim...@byosoft.com.cn>; Ard Biesheuvel > <ard.biesheu...@arm.com>; > > > Kinney, Michael D <michael.d.kin...@intel.com>; Leif Lindholm > > > <l...@nuviainc.com>; Ni, Ray <ray...@intel.com>; Schaefer, Daniel > > > <daniel.schae...@hpe.com>; Sunil V L <suni...@ventanamicro.com>; Ard > > > Biesheuvel <ardb+tianoc...@kernel.org> > > > Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > > > Hi, > > > > > > On Mon, Sep 06, 2021 at 02:04:48PM +0200, Ard Biesheuvel wrote: > > > > On Mon, 6 Sept 2021 at 13:44, Yao, Jiewen <jiewen....@intel.com> > > wrote: > > > > > > > > > > I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt > folder and > > > put all things there. > > > > > > > > > > I also think we define Fdt feature in > > > https://github.com/tianocore/edk2/blob/master/Maintainers.txt to add > > > reviewer there to help review the code. > > > > > > > > > > > > > Agreed. > > > > > > Agreeing too. > > > > > > take care, > > > Gerd > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80282): https://edk2.groups.io/g/devel/message/80282 Mute This Topic: https://groups.io/mt/85427656/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-