Dun: This PR also includes one additional commit to fix the build issue. Have you send the patch for it?
For this patch set, Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>. It will be merged after the build issue has been fixed. Thanks Liming > -----邮件原件----- > 发件人: Tan, Dun <dun....@intel.com> > 发送时间: 2021年8月30日 16:31 > 收件人: gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io > 抄送: 'Sean Brogan' <sean.bro...@microsoft.com>; 'Bret Barkelew' > <bret.barke...@microsoft.com>; Kinney, Michael D > <michael.d.kin...@intel.com> > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > gate-build-job.yml and CISetting.py > > Hi Liming, > > Here is the link of the PR to verify the change in Tiano EDKII. It passed the > CI > by GCC and VS both. > https://github.com/tianocore/edk2/pull/1931 > > Thanks, > Dun > -----Original Message----- > From: gaoliming <gaolim...@byosoft.com.cn> > Sent: Monday, August 30, 2021 11:26 AM > To: devel@edk2.groups.io; Tan, Dun <dun....@intel.com> > Cc: 'Sean Brogan' <sean.bro...@microsoft.com>; 'Bret Barkelew' > <bret.barke...@microsoft.com>; Kinney, Michael D > <michael.d.kin...@intel.com> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > in gate-build-job.yml and CISetting.py > > Dun: > I don't see the issues to enable UefiPayloadPkg in CI. Have you created the > private PR to verify this change? > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > > 发送时间: 2021年8月24日 17:24 > > 收件人: devel@edk2.groups.io > > 抄送: Sean Brogan <sean.bro...@microsoft.com>; Bret Barkelew > > <bret.barke...@microsoft.com>; Kinney, Michael D > > <michael.d.kin...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn> > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > > in gate-build-job.yml and CISetting.py > > > > Hi all, > > Since the CI for UefiPayloadPkg is important to our develop > > progress, would you please speed up the review process? Thanks a lot! > > > > Thanks, > > Dun Tan > > -----Original Message----- > > From: Tan, Dun <dun....@intel.com> > > Sent: Friday, August 20, 2021 2:44 PM > > To: devel@edk2.groups.io > > Cc: Sean Brogan <sean.bro...@microsoft.com>; Bret Barkelew > > <bret.barke...@microsoft.com>; Kinney, Michael D > > <michael.d.kin...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; > > Tan, Dun <dun....@intel.com> > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > > gate-build-job.yml and CISetting.py > > > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for > > UefiPayloadPkg. > > Add UefiPayloadPkg to supported Packages in CISettings. > > > > Cc: Sean Brogan <sean.bro...@microsoft.com> > > Cc: Bret Barkelew <bret.barke...@microsoft.com> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Signed-off-by: DunTan <dun....@intel.com> > > --- > > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ > > .pytool/CISettings.py | 3 ++- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml > > b/.azurepipelines/templates/pr-gate-build-job.yml > > index 207acc7631..d5b16c127f 100644 > > --- a/.azurepipelines/templates/pr-gate-build-job.yml > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml > > @@ -48,6 +48,9 @@ jobs: > > TARGET_SECURITY: > > Build.Pkgs: 'SecurityPkg' > > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > + TARGET_UEFIPAYLOAD: > > + Build.Pkgs: 'UefiPayloadPkg' > > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > TARGET_PLATFORMS: > > # For Platforms only check code. Leave it to Platform CI > > # to build them. > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index > > 96e6baa519..ce330e2c73 100644 > > --- a/.pytool/CISettings.py > > +++ b/.pytool/CISettings.py > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, > > UpdateSettingsManager, SetupSettingsManag > > "CryptoPkg", > > "UnitTestFrameworkPkg", > > "OvmfPkg", > > - "RedfishPkg" > > + "RedfishPkg", > > + "UefiPayloadPkg" > > ) > > > > def GetArchitecturesSupported(self): > > -- > > 2.31.1.windows.1 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79962): https://edk2.groups.io/g/devel/message/79962 Mute This Topic: https://groups.io/mt/85266573/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
