On Fri, Aug 27, 2021 at 03:16:43PM +0200, Ard Biesheuvel wrote: > On Tue, 24 Aug 2021 at 19:21, Jim Fehlig <jfeh...@suse.com> wrote: > > > > On 8/23/21 1:09 AM, Gary Lin wrote: > > > When using HVM Direct kernel boot with OvmfXen, it could fail at the > > > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > > > and PcdAcpiS3Enable. > > > > > > This patch series initializes PcdAcpiS3Enable in > > > . Besides, QemuFwCfgS3Enabled() is > > > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the > > > potential inconsistency. > > > > > > Bugzilla links: > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > > > > > v3: > > > - Update the description per Anthony's suggestion > > > - Add the bugzilla links > > > - Move the QemuKernelLoaderFsDxe patch out of this patch series > > > and make it an independent patch > > > v2: > > > - Amend the description and address "HVM Direct Kernel Boot" > > > - Add the comment for the conditional test of QemuFwCfgS3Enabled() > > > - Remove unused QemuFwCfgLib > > > - Update my email address > > > > > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > > Cc: Jiewen Yao <jiewen....@intel.com> > > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > > Cc: Anthony Perard <anthony.per...@citrix.com> > > > Cc: Julien Grall <jul...@xen.org> > > > Cc: Jim Fehlig <jfeh...@suse.com> > > > Cc: Joey Li <j...@suse.com> > > > > > > Gary Lin (4): > > > OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization > > > OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support > > > OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 > > > support > > > OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support > > > > > > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- > > > .../PlatformBootManagerLib.inf | 1 + > > > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++ > > > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ > > > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- > > > .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- > > > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +--- > > > OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ > > > 8 files changed, 22 insertions(+), 9 deletions(-) > > > > Tested-by: Jim Fehlig <jfeh...@suse.com> > > > > > Thanks for this series, and thanks all for the reviews. > > Gary, could you please resend it with the following changes so it > applies cleanly: > - Move the bugzilla link into the signoff block, preceded by Ref: > - Remove v[23] etc version information from the patches, or move it > below the three dashes line so it does not end up in the commit log > - Incorporate all the review tags given in response to this v3 Will update the patches.
> - Please find a way to send these patches that doesn't result in > mangled whitespace (hint: using Outlook/Exchange is probably not the > best choice) > Sorry for that. I forgot to set sendemail.transferEncoding to 8bit and git chose quoted-printable automatically. I've updated my git config and it should be fixed next time. Thanks, Gary Lin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79935): https://edk2.groups.io/g/devel/message/79935 Mute This Topic: https://groups.io/mt/85080300/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
