Reviewed-by: Dandan Bi <[email protected]>
Thanks, Dandan > -----Original Message----- > From: Wenyi Xie <[email protected]> > Sent: Thursday, August 26, 2021 9:16 AM > To: [email protected]; Wang, Jian J <[email protected]>; Wu, Hao A > <[email protected]>; Bi, Dandan <[email protected]>; Dong, Eric > <[email protected]> > Cc: [email protected]; [email protected] > Subject: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead > code block > > As the if statement outside has confirmed that > BlockData->Name == NULL, so the if statement inside > is always false. > > Cc: Jian J Wang <[email protected]> > Cc: Hao A Wu <[email protected]> > Cc: Dandan Bi <[email protected]> > Cc: Eric Dong <[email protected]> > Signed-off-by: Wenyi Xie <[email protected]> > --- > MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > index d492b769d51c..17a914208c6d 100644 > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > @@ -2871,9 +2871,6 @@ ParseIfrData ( > // > if ((BlockData->Name == NULL) && ((BlockData->Offset + BlockData- > >Width) > VarStorageData->Size)) { > Status = EFI_INVALID_PARAMETER; > - if (BlockData->Name != NULL) { > - FreePool (BlockData->Name); > - } > FreePool (BlockData); > goto Done; > } > -- > 2.20.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79877): https://edk2.groups.io/g/devel/message/79877 Mute This Topic: https://groups.io/mt/85151741/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
