Hey Rebecca,

I think even Uncrustify has issues with the EDK II indentation style. You might want to check the UEFI Talkbox Discord server, I had a brief chat with Michael about it there. I don't think realistically any tool supports EDK II's indentation style however, so I'd propose it is changed. This could be for new submissions only, or actually the entire codebase could be reformatted at once with a good tool setup. While this screws with git blame, the (to my understanding) decided on CRLF -> LF change does that anyway, so at least two evils could be dealt with in one go really.

Best regards,
Marvin

On 16/08/2021 21:34, Rebecca Cran wrote:

cc devel@ .

On 8/16/21 1:33 PM, Rebecca Cran wrote:

I noticed a message on Twitter about an idea of using Uncrustify for EDK2 instead of the ECC tool, and came across https://www.mail-archive.com/search?l=devel@edk2.groups.io&q=subject:%22Re%5C%3A+%5C%5Bedk2%5C-devel%5C%5D+TianoCore+Community+Meeting+Minutes+%5C-+2%5C%2F4%22&o=newest&f=1 .

I was wondering if there's been any progress on it that I could check out?


Michael Kubacki: in that message, you said:

"I'm planning to put up a branch that we can use as a reference for a conversation around uncrustify in the next couple of weeks."


Did you end up creating that branch, and if so could you provide a link to it please?


--
Rebecca Cran





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79384): https://edk2.groups.io/g/devel/message/79384
Mute This Topic: https://groups.io/mt/84932137/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to